Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 13 Oct 2014 06:51:41 +0000 (UTC)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r273028 - in head/sys/dev: msk nfe sk
Message-ID:  <201410130651.s9D6pfJ8057392@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: rwatson
Date: Mon Oct 13 06:51:40 2014
New Revision: 273028
URL: https://svnweb.freebsd.org/changeset/base/273028

Log:
  Eliminate unnecessary checking for M_EXT on mbufs returned by m_getjcl().
  
  Reviewed by:	bz, glebius, yongari
  MFC after:	3 days
  Sponsored by:	EMC / Isilon Storage Division
  Differential Revision:	https://reviews.freebsd.org/D938

Modified:
  head/sys/dev/msk/if_msk.c
  head/sys/dev/nfe/if_nfe.c
  head/sys/dev/sk/if_sk.c

Modified: head/sys/dev/msk/if_msk.c
==============================================================================
--- head/sys/dev/msk/if_msk.c	Mon Oct 13 06:50:08 2014	(r273027)
+++ head/sys/dev/msk/if_msk.c	Mon Oct 13 06:51:40 2014	(r273028)
@@ -962,10 +962,6 @@ msk_jumbo_newbuf(struct msk_if_softc *sc
 	m = m_getjcl(M_NOWAIT, MT_DATA, M_PKTHDR, MJUM9BYTES);
 	if (m == NULL)
 		return (ENOBUFS);
-	if ((m->m_flags & M_EXT) == 0) {
-		m_freem(m);
-		return (ENOBUFS);
-	}
 	m->m_len = m->m_pkthdr.len = MJUM9BYTES;
 	if ((sc_if->msk_flags & MSK_FLAG_RAMBUF) == 0)
 		m_adj(m, ETHER_ALIGN);

Modified: head/sys/dev/nfe/if_nfe.c
==============================================================================
--- head/sys/dev/nfe/if_nfe.c	Mon Oct 13 06:50:08 2014	(r273027)
+++ head/sys/dev/nfe/if_nfe.c	Mon Oct 13 06:51:40 2014	(r273028)
@@ -2063,10 +2063,6 @@ nfe_jnewbuf(struct nfe_softc *sc, int id
 	m = m_getjcl(M_NOWAIT, MT_DATA, M_PKTHDR, MJUM9BYTES);
 	if (m == NULL)
 		return (ENOBUFS);
-	if ((m->m_flags & M_EXT) == 0) {
-		m_freem(m);
-		return (ENOBUFS);
-	}
 	m->m_pkthdr.len = m->m_len = MJUM9BYTES;
 	m_adj(m, ETHER_ALIGN);
 

Modified: head/sys/dev/sk/if_sk.c
==============================================================================
--- head/sys/dev/sk/if_sk.c	Mon Oct 13 06:50:08 2014	(r273027)
+++ head/sys/dev/sk/if_sk.c	Mon Oct 13 06:51:40 2014	(r273028)
@@ -1012,10 +1012,6 @@ sk_jumbo_newbuf(sc_if, idx)
 	m = m_getjcl(M_NOWAIT, MT_DATA, M_PKTHDR, MJUM9BYTES);
 	if (m == NULL)
 		return (ENOBUFS);
-	if ((m->m_flags & M_EXT) == 0) {
-		m_freem(m);
-		return (ENOBUFS);
-	}
 	m->m_pkthdr.len = m->m_len = MJUM9BYTES;
 	/*
 	 * Adjust alignment so packet payload begins on a

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201410130651.s9D6pfJ8057392>