Date: Fri, 4 Jun 2021 18:55:06 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Tobias Kortkamp <tobik@freebsd.org> Cc: Piotr Kubaj <pkubaj@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f75b9b72e5cb - main - games/fheroes2: look for libpng without suffix, switch to PORTDOCS Message-ID: <YLp3Crr0xXKjZsES@FreeBSD.org> In-Reply-To: <YLp1vq9oofchSp3h@urd.tobik.me> References: <202106041251.154Cp68Z089802@gitrepo.freebsd.org> <YLp1vq9oofchSp3h@urd.tobik.me>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 04, 2021 at 08:49:34PM +0200, Tobias Kortkamp wrote: > On Fri, Jun 04, 2021 at 12:51:06PM +0000, Piotr Kubaj wrote: > > The branch main has been updated by pkubaj: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=f75b9b72e5cb7ac631cf10f936d185ecd434ad72 > > > > commit f75b9b72e5cb7ac631cf10f936d185ecd434ad72 > > Author: Piotr Kubaj <pkubaj@FreeBSD.org> > > AuthorDate: 2021-06-04 12:50:57 +0000 > > Commit: Piotr Kubaj <pkubaj@FreeBSD.org> > > CommitDate: 2021-06-04 12:50:57 +0000 > > > > games/fheroes2: look for libpng without suffix, switch to PORTDOCS > > I think this is missing > > Reported by: danfe It's okay, I'm not hunting for extra attribution, just for better code. > > -PLIST_FILES= bin/${PORTNAME} \ > > - ${DOCSDIR}/README.txt \ > > +PLIST_FILES= bin/${PORTNAME} > > +PORTDOCS= ${DOCSDIR}/README.txt \ > > ${DOCSDIR}/changelog.txt > > This won't work. Files in PORTDOCS are relative to ${DOSCDIR} so > you need to drop ${DOCSDIR}/. Also PORTDOCS won't do anything > without adding a DOCS option. Yes, I've also noticed that while on the bus (via phone) so could not reply. Thanks for following up Tobias. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YLp3Crr0xXKjZsES>