Date: Sun, 16 Jun 2002 14:30:29 +0200 From: Oliver Braun <obraun@informatik.unibw-muenchen.de> To: Kris Kennaway <kris@obsecurity.org> Cc: ijliao@freebsd.org, ports@freebsd.org, current@freebsd.org Subject: Re: rsync 5.x breakage Message-ID: <20020616123029.GA12998@informatik.unibw-muenchen.de> In-Reply-To: <20020616040000.A16402@xor.obsecurity.org> References: <20020616040000.A16402@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[CC ports@ and current@]
* Kris Kennaway <kris@obsecurity.org> [2002-06-16 13:02]:
> Looks like the ${REINPLACE_CMD} patch didn't work:
> http://bento.freebsd.org/errorlogs/5-latest/rsync-2.5.5_1.log
Fixed in PR ports/39365.
But I am not very happy with that fix.
The problem is that sed(1) on -current fails with "sed -i.bak file", if
file.bak already exists, but perl does not. Since net/rsync/Makefile
uses 3 ${REINPLACE_CMD}s on one file (rsync.h), I have removed the
backup file with ${RM} file.bak between the calls.
==> ${REINPLACE_CMD} has different semantics on -current and -stable
Maintainer only using -stable won't be able to get that error and fix it
_before_ submitting.
The extension bak has to be hardcoded in the Makefile. This is not very
sexy, and after a change of ${REINPLACE_CMD} to something like sed
-i.orig this will fail again.
So, what about changing sed(1) on -current to unify semantics of
${REINPLACE_CMD}?
Regards,
Olli
--
IST & IIS _ INF _ UniBwM ___________ http://ist.unibw-muenchen.de/People/obraun/
Tele-Consulting GmbH _______________ http://www.tele-consulting.com/ ___ obraun@
FreeBSD: The Power To Serve ________ http://www.freebsd.org/ ___________________
GnuPG: 0xEF25B1BA Fingerprint: 6A3B 042A 732E 17E4 B6E7 3EAF C0B1 6B7D EF25 B1BA
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020616123029.GA12998>