Date: Sun, 16 Aug 2009 19:19:04 GMT From: Piotr Smyrak <smyru@heron.pl> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/137855: early identify port conflicts Message-ID: <200908161919.n7GJJ4ER051758@www.freebsd.org> Resent-Message-ID: <200908161920.n7GJK4T6098035@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 137855
>Category: ports
>Synopsis: early identify port conflicts
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Aug 16 19:20:04 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Piotr Smyrak
>Release: 7.2-STABLE
>Organization:
>Environment:
FreeBSD dsk.smyrak.com 7.2-STABLE FreeBSD 7.2-STABLE #0: Thu Jul 30 20:23:13 CEST 2009 root@dsk.smyrak.com:/usr/obj/usr/src/sys/SMYRU i386
>Description:
Currently the port build checks for existing conflicts very late after install-message target.
Just imagine a situation where one has to download a big tarball, build it, and out of sudden, when everything is prepared, even dependences were installed, the port will refuse to cooperate due to a conflict. Fine if it can be safely resolved, but quite annoying, when the conflicting app is needed and cannot be removed.
Moving check-conflicts target before check-depends into _SANITY_SEQ sounds quite logical and safe. See attached patch.
>How-To-Repeat:
>Fix:
Apply the attached patch
Patch attached with submission follows:
--- bsd.port.mk.orig 2009-08-16 21:00:55.000000000 +0200
+++ bsd.port.mk 2009-08-16 21:06:45.000000000 +0200
@@ -4160,10 +4160,10 @@
.else
_CHROOT_SEQ=
.endif
-_SANITY_SEQ= ${_CHROOT_SEQ} pre-everything check-makefile check-categories \
- check-makevars check-desktop-entries check-depends \
- check-deprecated check-vulnerable buildanyway-message \
- options-message
+_SANITY_SEQ= ${_CHROOT_SEQ} pre-everything check-makefile \
+ check-categories check-makevars check-desktop-entries \
+ check-conflicts check-depends check-deprecated \
+ check-vulnerable buildanyway-message options-message
_FETCH_DEP= check-sanity
_FETCH_SEQ= fetch-depends pre-fetch pre-fetch-script \
do-fetch post-fetch post-fetch-script
@@ -4182,8 +4182,7 @@
_BUILD_SEQ= build-message pre-build pre-build-script do-build \
post-build post-build-script
_INSTALL_DEP= build
-_INSTALL_SEQ= install-message check-conflicts \
- run-depends lib-depends apply-slist pre-install \
+_INSTALL_SEQ= install-message run-depends lib-depends apply-slist pre-install \
pre-install-script generate-plist check-already-installed
_INSTALL_SUSEQ= check-umask install-mtree pre-su-install \
pre-su-install-script do-install install-desktop-entries \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908161919.n7GJJ4ER051758>