Date: Tue, 22 Nov 2005 16:37:21 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci_link.c Message-ID: <20051122143721.GE65080@ip.net.ua> In-Reply-To: <200511212201.jALM1Ggp080941@repoman.freebsd.org> References: <200511212201.jALM1Ggp080941@repoman.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Nov 21, 2005 at 10:01:16PM +0000, John Baldwin wrote: > jhb 2005-11-21 22:01:16 UTC > > FreeBSD src repository > > Modified files: > sys/dev/acpica acpi_pci_link.c > Log: > Fix the code to look up the BIOS IRQ for a given link device by reading > the IRQ set by the BIOS in existing devices to actually get the correct > bus number of the child PCI bus. I was not reading the bus number from > the bridge device correctly. The __BUS_ACCESSOR() macros (from which > pcib_get_bus() is built) assume that the passed in argument is a child > device. However, at the time I'm reading the bus there is no child > device yet, so I was passing in the pcib device as the child device. > The parent of the pcib device probably returned an error in the case of > a host bridge, thus resulting in random stack garbage for the bus number. > For PCI-PCI bridges, the bus number being used was actually the subvendor > of the PCI-PCI bridge device itself. > > MFC after: 1 week > > Revision Changes Path > 1.49 +15 -3 src/sys/dev/acpica/acpi_pci_link.c > Looks like I no longer need these hw.pci.link.LNK[A-D].irq=11 in /boot/loader.conf after this change. Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDgy0hqRfpzJluFF4RAlcCAJ9uDbKl9/6xqX471BVMfip5IL9KjQCdHLyR aISBx/qSS8zIm/LgDUwNEEw= =eqiM -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051122143721.GE65080>