Date: Tue, 12 Dec 2006 06:24:45 -0800 From: Luigi Rizzo <rizzo@icir.org> To: ticso@cicely.de Cc: cvs-src@FreeBSD.org, Luigi Rizzo <luigi@FreeBSD.org>, src-committers@FreeBSD.org, imp@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c Message-ID: <20061212062445.A61903@xorpc.icir.org> In-Reply-To: <20061212141759.GZ54209@cicely12.cicely.de>; from ticso@cicely12.cicely.de on Tue, Dec 12, 2006 at 03:17:59PM %2B0100 References: <200612081036.kB8AakMD029277@repoman.freebsd.org> <20061212131333.GU54209@cicely12.cicely.de> <20061212055756.A61182@xorpc.icir.org> <20061212141759.GZ54209@cicely12.cicely.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 12, 2006 at 03:17:59PM +0100, Bernd Walter wrote: > On Tue, Dec 12, 2006 at 05:57:56AM -0800, Luigi Rizzo wrote: ... > > then i suppose the proper fix is to revert to m_copy() and > > work on if_simloop() so that 1. it handles a readonly chain, and > > 2. when doing so, it passes up a properly aligned packet... > > Can't comment on this, as I don't have enough knowledge about network > code. > According to the xscale report it was likely never properly aligned, > the alignment obviously just moved with your change. > > > however note that there is already some code in net/if_loop.c::if_simloop(), > > just that it uses this: > > > > #if defined(__ia64__) || defined(__sparc64__) ... > > to detect whether the architecture is alignment-sensitive. > > Is there any other identifier that we can use to check ? > > I wonder how many of these are missing __arm__? and this is why i wonder if there is a generic identifier that we can use to provide alignment. cheers luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061212062445.A61903>