Date: Sat, 24 Mar 2012 14:30:47 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: David Chisnall <theraven@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r233391 - head/contrib/libstdc++/libsupc++ Message-ID: <4F6E20E7.8040206@FreeBSD.org> In-Reply-To: <201203232010.q2NKAuIE092217@svn.freebsd.org> References: <201203232010.q2NKAuIE092217@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ahem.. On 03/23/12 15:10, David Chisnall wrote: > Author: theraven > Date: Fri Mar 23 20:10:56 2012 > New Revision: 233391 > URL: http://svn.freebsd.org/changeset/base/233391 > > Log: > Revert ABI breakage in libsupc++. > > Unfortunately, the ABI was broken upstream for the 4.2 release, which we > imported. We then shipped the broken version for several years and certain > ports (e.g. libobjc2) depend on it, so we're stuck with it for now... > > We should revisit this for 10.0, since we're allowed to break the ABI then, but > until then we should keep the ABI we shipped with 8.x and 9.x. > > Reviewed by: kan > Approved by: dim (mentor) > MFC after: 1 week > > Modified: > head/contrib/libstdc++/libsupc++/typeinfo > > Let me try to recap: gcc-4.2.1 broke the ABI and we shipped it for a long time. The bug was detected by Apple and others: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35081 It was fixed for gcc-4.2.2 (which we didn't ship): http://gcc.gnu.org/viewcvs?view=revision&revision=129061 <http://gcc.gnu.org/viewcvs?view=revision&revision=129061>; I inadvertently fixed the bug 3 months ago when I brought in the last LGPLv2 updates for libstdc++: http://svnweb.freebsd.org/base?view=revision&revision=228780 <http://svnweb.freebsd.org/base?view=revision&revision=228780>; The fix hasn't been shipped but was MFC'd and is actually in 8.3-RC* !! David's commit actually restores the gcc 4.2.1 bug (?). Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F6E20E7.8040206>