Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Jan 2017 20:29:50 +0000 (UTC)
From:      Ngie Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r311140 - in head: . secure/lib/libssh secure/usr.bin/ssh secure/usr.sbin/sshd
Message-ID:  <201701022029.v02KToX9081747@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Mon Jan  2 20:29:50 2017
New Revision: 311140
URL: https://svnweb.freebsd.org/changeset/base/311140

Log:
  Only bake krb5_config.h support in to ssh(3), etc if both MK_GSSAPI and
  MK_KERBEROS_SUPPORT != no
  
  This fixes the odd case where someone specified MK_GSSAPI=no and
  MK_KERBEROS_SUPPORT=yes (which admittedly, probably doesn't make sense,
  but the build system doesn't prevent this case today, and it didn't when
  I filed the bug back in 2011 either).
  
  MFC after:	2 weeks
  PR:		159745

Modified:
  head/Makefile.inc1
  head/secure/lib/libssh/Makefile
  head/secure/usr.bin/ssh/Makefile
  head/secure/usr.sbin/sshd/Makefile

Modified: head/Makefile.inc1
==============================================================================
--- head/Makefile.inc1	Mon Jan  2 20:24:10 2017	(r311139)
+++ head/Makefile.inc1	Mon Jan  2 20:29:50 2017	(r311140)
@@ -2156,7 +2156,7 @@ secure/lib/libssh__L: lib/libz__L secure
 .if ${MK_LDNS} != "no"
 secure/lib/libssh__L: lib/libldns__L
 .endif
-.if ${MK_KERBEROS_SUPPORT} != "no"
+.if ${MK_GSSAPI} != "no" && ${MK_KERBEROS_SUPPORT} != "no"
 secure/lib/libssh__L: lib/libgssapi__L kerberos5/lib/libkrb5__L \
     kerberos5/lib/libhx509__L kerberos5/lib/libasn1__L lib/libcom_err__L \
     lib/libmd__L kerberos5/lib/libroken__L

Modified: head/secure/lib/libssh/Makefile
==============================================================================
--- head/secure/lib/libssh/Makefile	Mon Jan  2 20:24:10 2017	(r311139)
+++ head/secure/lib/libssh/Makefile	Mon Jan  2 20:29:50 2017	(r311140)
@@ -46,7 +46,7 @@ LIBADD+=	ldns
 CFLAGS+= -I${SSHDIR} -include ssh_namespace.h
 SRCS+=	 ssh_namespace.h
 
-.if ${MK_KERBEROS_SUPPORT} != "no"
+.if ${MK_GSSAPI} != "no" && ${MK_KERBEROS_SUPPORT} != "no"
 CFLAGS+= -include krb5_config.h
 SRCS+=	 krb5_config.h
 .endif

Modified: head/secure/usr.bin/ssh/Makefile
==============================================================================
--- head/secure/usr.bin/ssh/Makefile	Mon Jan  2 20:24:10 2017	(r311139)
+++ head/secure/usr.bin/ssh/Makefile	Mon Jan  2 20:29:50 2017	(r311140)
@@ -23,7 +23,7 @@ LIBADD=	ssh
 CFLAGS+=	-DHAVE_LDNS=1
 .endif
 
-.if ${MK_KERBEROS_SUPPORT} != "no"
+.if ${MK_GSSAPI} != "no" && ${MK_KERBEROS_SUPPORT} != "no"
 CFLAGS+= -include krb5_config.h
 SRCS+=	krb5_config.h
 LIBADD+=	gssapi

Modified: head/secure/usr.sbin/sshd/Makefile
==============================================================================
--- head/secure/usr.sbin/sshd/Makefile	Mon Jan  2 20:24:10 2017	(r311139)
+++ head/secure/usr.sbin/sshd/Makefile	Mon Jan  2 20:29:50 2017	(r311140)
@@ -47,7 +47,7 @@ LIBADD+= blacklist
 LDFLAGS+=-L${LIBBLACKLISTDIR}
 .endif
 
-.if ${MK_KERBEROS_SUPPORT} != "no"
+.if ${MK_GSSAPI} != "no" && ${MK_KERBEROS_SUPPORT} != "no"
 CFLAGS+= -include krb5_config.h
 SRCS+=	krb5_config.h
 LIBADD+=	gssapi_krb5 gssapi krb5



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701022029.v02KToX9081747>