Date: Fri, 2 Feb 2024 23:24:29 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Warner Losh <imp@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 834517eff8aa - main - x86 & arm: remove CAM_DEBUG_FLAGS= from MMCCAM kernels Message-ID: <76A2B22D-565F-4CC5-B135-291624DA1E1F@freebsd.org> In-Reply-To: <a4ba5dc5-2918-4729-9018-f8bca3018f65@FreeBSD.org> References: <202402021959.412JxKop038336@gitrepo.freebsd.org> <a4ba5dc5-2918-4729-9018-f8bca3018f65@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2 Feb 2024, at 22:45, John Baldwin <jhb@FreeBSD.org> wrote: > On 2/2/24 11:59 AM, Warner Losh wrote: >> The branch main has been updated by imp: >> URL: https://cgit.FreeBSD.org/src/commit/?id=834517eff8aaab46760645619b880d97f23ab61b >> commit 834517eff8aaab46760645619b880d97f23ab61b >> Author: Mina Galić <freebsd@igalic.co> >> AuthorDate: 2024-02-02 19:46:01 +0000 >> Commit: Warner Losh <imp@FreeBSD.org> >> CommitDate: 2024-02-02 19:51:51 +0000 >> x86 & arm: remove CAM_DEBUG_FLAGS= from MMCCAM kernels >> we leave `options CAMDEBUG` enabled, so that when needed, CAM debugging >> can be enabled *as needed*, rather than setting a default of everything. >> Reviewed by: imp >> Pull Request: https://github.com/freebsd/freebsd-src/pull/798 >> --- > > Would it make sense to have a sys/conf/std.MMCCAM and the various GENERIC-MMCCAM > could just be include GENERIC, ident, include std.MMCCAM? > > (Related, I wonder if we want to have std.DEBUG and std.NODEBUG for use in > GENERIC and GENERIC-*DEBUG.) We have sys/conf/std.nodebug (not NODEBUG, which slightly bugs me) already. Extending the set of things would be sensible. I’d also like to see a std.GENERIC that includes all the MI things you expect in a GENERIC kernel, and I guess a std.MINIMAL that’s the core subset of that. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?76A2B22D-565F-4CC5-B135-291624DA1E1F>