Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 12 Jul 2014 09:31:23 -0600
From:      Ian Lepore <ian@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, David Chisnall <theraven@freebsd.org>, Bruce Simpson <bms@fastmail.net>, Bruce Evans <brde@optusnet.com.au>, svn-src-head@freebsd.org
Subject:   Re: svn commit: r268566 - head/usr.bin/users
Message-ID:  <1405179083.91430.14.camel@revolution.hippie.lan>
In-Reply-To: <20140712132705.GA45964@FreeBSD.org>
References:  <201407120747.s6C7lpYE020200@svn.freebsd.org> <20140712195452.N3279@besplex.bde.org> <53C12C1D.8080101@fastmail.net> <20140712132705.GA45964@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2014-07-12 at 13:27 +0000, Alexey Dokuchaev wrote:
> On Sat, Jul 12, 2014 at 01:37:49PM +0100, Bruce Simpson wrote:
> > On 12/07/2014 12:34, Bruce Evans wrote:
> > >This joke is bad.  The C++ version is worse in every way.
> > 
> > I concur with everything you have said in your message. Moral of story: it
> > is very, very easy to introduce bloat using C++, and using a higher level
> > language does not automatically lead to better code quality.
> 
> +1.  Now the question is, how do we come out of this mess?  Shall we redo
> it in C again?  Polish C++ version?  Merge it with w(1) as suggested?
> 
> ./danfe
> 

It is in no way established that any kind of "mess" exists.  All we have
is some people who appear to hate C++ expressing their opinions about
how they hate C++.  All the whining about how many more bytes the
compiled code is or many milliseconds something takes to compile don't
add up to any actual problem.

My opinion is that the original commit message was exactly correct:  The
code was rewritten to be cleaner and easier to understand and maintain.
We need more of the same.

-- Ian





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1405179083.91430.14.camel>