Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 7 Feb 2015 21:29:17 +0000 (UTC)
From:      Garrett Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r278364 - head/sys/dev/cxgb
Message-ID:  <201502072129.t17LTHeI020952@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Sat Feb  7 21:29:17 2015
New Revision: 278364
URL: https://svnweb.freebsd.org/changeset/base/278364

Log:
  Remove kdb_backtrace extern; get the definition for kdb_backtrace from
  <sys/kdb.h> instead
  
  Fix whitespace in WARN_ON macro definition
  
  MFC after: 1 week
  Reviewed by: np
  Differential Revision: https://reviews.freebsd.org/D1799
  Sponsored by: EMC / Isilon Storage Division

Modified:
  head/sys/dev/cxgb/cxgb_osdep.h

Modified: head/sys/dev/cxgb/cxgb_osdep.h
==============================================================================
--- head/sys/dev/cxgb/cxgb_osdep.h	Sat Feb  7 19:51:34 2015	(r278363)
+++ head/sys/dev/cxgb/cxgb_osdep.h	Sat Feb  7 21:29:17 2015	(r278364)
@@ -39,6 +39,8 @@ $FreeBSD$
 #include <sys/lock.h>
 #include <sys/mutex.h>
 
+#include <sys/kdb.h>
+
 #include <dev/mii/mii.h>
 
 #ifndef _CXGB_OSDEP_H_
@@ -128,10 +130,8 @@ void prefetch(void *x) 
 #define smp_mb() mb()
 
 #define L1_CACHE_BYTES 128
-extern void kdb_backtrace(void);
-
 #define WARN_ON(condition) do { \
-       if (__predict_false((condition)!=0)) {  \
+	if (__predict_false((condition)!=0)) {  \
                 log(LOG_WARNING, "BUG: warning at %s:%d/%s()\n", __FILE__, __LINE__, __FUNCTION__); \
                 kdb_backtrace(); \
         } \



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201502072129.t17LTHeI020952>