Date: Tue, 18 Dec 2007 15:34:06 +0100 From: "Julian H. Stacey" <jhs@berklix.org> To: stable@freebsd.org Subject: Re: 7.0BETA4 /usr/src/gnu/usr.bin/cc/cc_int Thrashes Message-ID: <200712181434.lBIEY6jB095569@fire.js.berklix.net> In-Reply-To: <200712181108.lBIB8rAL090380@fire.js.berklix.net> References: <200712181108.lBIB8rAL090380@fire.js.berklix.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> Has 7.0-BETA4 perhaps wrongly got a -pipe in the .mk macros ?
> Please someone with generic 7.0BETA4 check with eg:
> A single line /etc/make.conf
> CFLAGS += -Dzonk=bla
> ~/tmp/Makefile
> tst:
> @echo "XX ${CFLAGS} YY"
> make tst
> XX -O2 -fno-strict-aliasing -pipe -Dzonk=bla YY
> Is pipe coming from generic mk/ ?
> Or from my local hacked version ?
> Could someone test please:
> My /usr/src is no longer generic, on a very slow CPU, SLIP
> linked, building rest of src/ & I'm about to go away, &
> will miss the 7-RELEASE date, but -pipe should not be in
> generic, needs to be a host dependent choice. )
Error found. I will send-pr. Patch below stored in :
http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/share/mk/sys.mk.REL=ALL.diff
pipe should not be on by default as
- It cripples machines with limited memory.
- Pipe can be enabled by any memory rich host in /etc/make.conf with:
CFLAGS += -pipe
- Man cc lists how to turn it on but not off.
- Man cc also notes assembler problems
*** /pub/FreeBSD/branches/-current/src/share/mk/sys.mk.orig Tue Dec 18 15:11:26 2007
--- /pub/FreeBSD/branches/-current/src/share/mk/sys.mk Tue Dec 18 15:12:23 2007
***************
*** 36,44 ****
.else
CC ?= cc
.if ${MACHINE_ARCH} == "arm"
! CFLAGS ?= -O -fno-strict-aliasing -pipe
.else
! CFLAGS ?= -O2 -fno-strict-aliasing -pipe
.endif
.if defined(NO_STRICT_ALIASING)
CFLAGS += -fno-strict-aliasing
--- 36,44 ----
.else
CC ?= cc
.if ${MACHINE_ARCH} == "arm"
! CFLAGS ?= -O -fno-strict-aliasing
.else
! CFLAGS ?= -O2 -fno-strict-aliasing
.endif
.if defined(NO_STRICT_ALIASING)
CFLAGS += -fno-strict-aliasing
*** 6.2-RELEASE/src/share/mk/sys.mk.orig Tue Sep 18 09:32:40 2007
--- 6.2-RELEASE/src/share/mk/sys.mk Tue Dec 18 15:21:09 2007
***************
*** 35,41 ****
CFLAGS ?= -O
.else
CC ?= cc
! CFLAGS ?= -O2 -fno-strict-aliasing -pipe
.endif
CXX ?= c++
--- 35,41 ----
CFLAGS ?= -O
.else
CC ?= cc
! CFLAGS ?= -O2 -fno-strict-aliasing
.endif
CXX ?= c++
--
Julian Stacey. Munich Computer Consultant, BSD Unix C Linux. http://berklix.com
Ihr Rauch = mein allergischer Kopfschmerz. Dump cigs 4 snuff.
--
Julian Stacey. Munich Computer Consultant, BSD Unix C Linux. http://berklix.com
Ihr Rauch = mein allergischer Kopfschmerz. Dump cigs 4 snuff.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712181434.lBIEY6jB095569>