Date: Thu, 10 May 2018 23:00:47 +0000 (UTC) From: Bryan Drewery <bdrewery@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org Subject: svn commit: r469590 - branches/2018Q2/Mk/Scripts Message-ID: <201805102300.w4AN0lCH083723@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: bdrewery Date: Thu May 10 23:00:46 2018 New Revision: 469590 URL: https://svnweb.freebsd.org/changeset/ports/469590 Log: MFH: r469589 stage-qa: Change stripped check to only look for .debug_info. 'strip -x', and splitting out debug symbols with objcopy, will leave a .symtab section but will still remove the .debug_info section. file(1) shows this distinction as well after the use of 'strip -x': work/tcl8.7a1/unix/libtcl8.7.so: ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically linked, with debug_info, not stripped work/stage/usr/local/lib/libtcl8.7.so: ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically linked, not stripped This fixes false-positives when using install-strip and symbol splitting. With hat: portmgr Approved by: portmgr (implicit) Modified: branches/2018Q2/Mk/Scripts/qa.sh Directory Properties: branches/2018Q2/ (props changed) Modified: branches/2018Q2/Mk/Scripts/qa.sh ============================================================================== --- branches/2018Q2/Mk/Scripts/qa.sh Thu May 10 23:00:15 2018 (r469589) +++ branches/2018Q2/Mk/Scripts/qa.sh Thu May 10 23:00:46 2018 (r469590) @@ -210,7 +210,7 @@ stripped() { find ${STAGEDIR} -type f ! -name '*.a' ! -name '*.o' \ -exec readelf -S {} + 2>/dev/null | awk '\ /File:/ {sub(/File: /, "", $0); file=$0} \ - /SYMTAB/ {print file}' | + /[[:space:]]\.debug_info[[:space:]]*PROGBITS/ {print file}' | while read f; do warn "'${f#${STAGEDIR}${PREFIX}/}' is not stripped consider trying INSTALL_TARGET=install-strip or using \${STRIP_CMD}" done
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805102300.w4AN0lCH083723>