Date: Mon, 7 Apr 2014 18:18:15 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Muhammad Moinur Rahman <5u623l20@gmail.com>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r350329 - in head/devel/bisoncpp: . files Message-ID: <CAMHz58Rt3sMV7gXNfSdOVD%2Bha7%2BK8y%2BoDggi23Qj15z7N5U19Q@mail.gmail.com> In-Reply-To: <alpine.LSU.2.11.1404070144430.5303@tuna.site> References: <201404060549.s365nYuf010306@svn.freebsd.org> <alpine.LSU.2.11.1404070144430.5303@tuna.site>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 7, 2014 at 7:49 AM, Gerald Pfeifer <gerald@pfeifer.com> wrote: > On Sun, 6 Apr 2014, Sunpoet Po-Chuan Hsieh wrote: >> Log: >> - Update to 4.08.00 >> - Pass maintainership to submitter >> - While I'm here, relax USE_GCC to yes >> >> Changes: http://sourceforge.net/projects/bisoncpp/files/bisonc%2B%2B/4.08.00/README/view >> http://sourceforge.net/projects/bisoncpp/files/bisonc%2B%2B/4.07.00/README/view >> http://sourceforge.net/projects/bisoncpp/files/bisonc%2B%2B/4.06.00/README/view >> PR: 188267 >> Submitted by: Muhammad Moinur Rahman <5u623l20@gmail.com> > >> Modified: head/devel/bisoncpp/Makefile >> ============================================================================== >> -USE_GCC= 4.7 >> +USE_GCC= yes > > This change is not correct. > > Check out the following lines later in this Makefile: > > @${REINPLACE_CMD} 's|"g++|"g++47|' \ > ${WRKSRC}/INSTALL.im \ > ${WRKSRC}/scanner/driver/build \ > ${WRKSRC}/parser/driver/build > @${REINPLACE_CMD} 's|"gcc|"gcc47|' \ > ${WRKSRC}/icmake/special > > This works by chance today since USE_GCC=yes defaults to GCC 4.7. > > It will break for anyone installing (only) lang/gcc48 or when we > switch to GCC 4.8 as default. > > Can you please fix this? > > Gerald > > PS: If ${CC} is set at this point, that would be the best option > instead of hard-coding things. Thank you, Gerald. I should use CC and CXX here. Is it OK? Index: Makefile =================================================================== --- Makefile (revision 350329) +++ Makefile (working copy) @@ -47,11 +47,11 @@ @${REINPLACE_CMD} 's|%%PREFIX%%|${PREFIX}|g; \ s|%%PORTVERSION%%|${PORTVERSION}|g' \ ${WRKSRC}/INSTALL.im - @${REINPLACE_CMD} 's|"g++|"g++47|' \ + @${REINPLACE_CMD} 's|"g++|"${CXX}|' \ ${WRKSRC}/INSTALL.im \ ${WRKSRC}/scanner/driver/build \ ${WRKSRC}/parser/driver/build - @${REINPLACE_CMD} 's|"gcc|"gcc47|' \ + @${REINPLACE_CMD} 's|"gcc|"${CC}|' \ ${WRKSRC}/icmake/special @${REINPLACE_CMD} 's|"cp -d |"cp -Pp | ; \ s|"cp -r |"cp -R | ; \ Regards, sunpoet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58Rt3sMV7gXNfSdOVD%2Bha7%2BK8y%2BoDggi23Qj15z7N5U19Q>