Date: Tue, 25 Jan 2000 21:18:06 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: Brett Glass <brett@lariat.org> Cc: Warner Losh <imp@village.org>, security@FreeBSD.ORG Subject: Re: Merged patches Message-ID: <200001260518.VAA08275@apollo.backplane.com> References: <4.2.2.20000125133808.019fd6a0@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
:
:P.S. -- In any event, the even greater advantage of using switches
:is an enhanced ability to cover all cases and to verify code
:correctness (and completeness) by inspection. If one can do this
:AND improve performance, it's a serious win.
No. There is a time and place for the use of a switch statement to
cover all your bases, but a *flags* field is *NOT* it. You are obviously
not willing to listen to reason. The plain fact of the matter is that
even if you were given the benefit of the doubt, the performance
improvement would be so miniscule that it would not be measureable.
Making these sorts of changes to perfectly good, working, and well
tested code is a great way to screw up said code. We are not going to
improve the TCP stack by wasting time on non-productive changes.
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001260518.VAA08275>