Date: Fri, 3 Nov 2017 23:53:39 -0600 From: Warner Losh <imp@bsdimp.com> To: Xin Li <delphij@delphij.net> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Xin LI <d@delphij.net> Subject: Re: svn commit: r325378 - head/sys/dev/ipmi Message-ID: <CANCZdfrj%2BMUTyHOj=LKzR5RbajiuB7R_MQK40wHSCcf7vSFuTA@mail.gmail.com> In-Reply-To: <39aedfe2-da6c-8f21-75bb-334a9d8389bd@delphij.net> References: <201711040301.vA431wdY002757@repo.freebsd.org> <39aedfe2-da6c-8f21-75bb-334a9d8389bd@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 3, 2017 at 11:29 PM, Xin Li <delphij@delphij.net> wrote: > > > On 11/3/17 20:01, Warner Losh wrote: > > Author: imp > > Date: Sat Nov 4 03:01:58 2017 > > New Revision: 325378 > > URL: https://svnweb.freebsd.org/changeset/base/325378 > > > > Log: > > Make the startup timeout 0 seconds by default rathern than 420s. This > > makes the default fail safe when watchdogd is disabled (which is also > > the default). > > I'm not sure if this is good: what if watchdogd is enabled, but the > system get stuck before watchdogd starts? > Correct. This feature has to be opt-in on top of watchdogd. If you don't add-in this feature, you won't have this new protection. You have to set hw.ipmi.wd_startup_countdown to activate it. More complicated logic may be possible, but the ipmi driver has no clue if watchdogd is enabled, so I'm not sure I see a path forward to automatically doing the right thing with sensible defaults. Have I overlooked something? Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrj%2BMUTyHOj=LKzR5RbajiuB7R_MQK40wHSCcf7vSFuTA>