Date: Sat, 22 Dec 2018 04:38:52 +0300 From: Yuri Pankov <yuripv@yuripv.net> To: freebsd-hackers <freebsd-hackers@freebsd.org> Subject: is adding new private symbols to libc frowned upon? Message-ID: <e120678a-359b-5131-3866-219d4c3cd796@yuripv.net>
next in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EhiOZGbFucnSj3LgI79UfCuSKsOhehwe5 Content-Type: multipart/mixed; boundary="CoWJRoNTpJ1quOjP17OCk5IjGCqJB7m7E"; protected-headers="v1" From: Yuri Pankov <yuripv@yuripv.net> To: freebsd-hackers <freebsd-hackers@freebsd.org> Message-ID: <e120678a-359b-5131-3866-219d4c3cd796@yuripv.net> Subject: is adding new private symbols to libc frowned upon? --CoWJRoNTpJ1quOjP17OCk5IjGCqJB7m7E Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Essentially, I need the __collate_equiv_value symbol to be visible to libregex for the changes in https://reviews.freebsd.org/D18531. Is the following change OK (it works, at least), or should try to avoid that? --- a/lib/libc/locale/Symbol.map +++ b/lib/libc/locale/Symbol.map @@ -212,6 +212,7 @@ FBSD_1.3 { FBSDprivate_1.0 { _PathLocale; __detect_path_locale; + __collate_equiv_value; __collate_load_error; __collate_range_cmp; }; --CoWJRoNTpJ1quOjP17OCk5IjGCqJB7m7E-- --EhiOZGbFucnSj3LgI79UfCuSKsOhehwe5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlwdlawACgkQk4vgf7Eq 4Wz1UwgAutD4hpHvWLBiFnJdFPmhaZk7GpSQqPD6npFuogpnBFiW++hSsUbsI5CY 7dRovng87sGLLA8UFG4bUJE1xKThF2/jUdjWJZsdCkq8LcgRPpTajPekGJ1ozH20 ZFP6vhLBRFYi3myHNmCfbGJIsIuGJF5aIwfqkyTD88mUCUyDIOzsr2vfW7W0+JjP 8DooEXckHU9UNGN5qAQlxHd2ePfpHN/qTHNd8KfjclDDpQuHsT4JlUvp7gMuj5m5 BjPki0X1voaVZg11RwE8m5/Uz7a/ty2n2LoVOUbtc1N4Z1xM80ILJt5z97O+/9Yp ezbJpblIIZuQX2DGro16Dt0e2yWIFw== =1qid -----END PGP SIGNATURE----- --EhiOZGbFucnSj3LgI79UfCuSKsOhehwe5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e120678a-359b-5131-3866-219d4c3cd796>