Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Apr 2010 19:44:34 -0700
From:      Garrett Cooper <yanefbsd@gmail.com>
To:        Eitan Adler <eitanadlerlist@gmail.com>
Cc:        freebsd-hackers@freebsd.org, Ruben de Groot <mail25@bzerk.org>, Doug Barton <dougb@freebsd.org>, "Aryeh M. Friedman" <aryeh.friedman@gmail.com>, =?ISO-8859-1?Q?Trond_Endrest=F8l?= <Trond.Endrestol@fagskolen.gjovik.no>
Subject:   Re: regenerating /var/db/pkg
Message-ID:  <j2p7d6fde3d1004251944x8776db97z1482f6cb10e1ea64@mail.gmail.com>
In-Reply-To: <u2sa0777e081004221005ja2bca37ame13007df67898fcd@mail.gmail.com>
References:  <4BCE5ECC.6070202@gmail.com> <4BCFE209.20501@FreeBSD.org> <20100422111758.GA39338@ei.bzerk.org> <o2oa0777e081004220521sae3b1b06o884fd8eadffc6931@mail.gmail.com> <alpine.BSF.2.00.1004221610520.29574@mail.fig.ol.no> <p2oa0777e081004220908w775b40e7r86f0c978b1a05d1e@mail.gmail.com> <4BD07F2D.3030809@FreeBSD.org> <4BD07FCB.4030604@FreeBSD.org> <u2sa0777e081004221005ja2bca37ame13007df67898fcd@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 22, 2010 at 10:05 AM, Eitan Adler <eitanadlerlist@gmail.com> wr=
ote:
> Same as before - if all is good I'll send a PR
>
> #!/bin/sh
> #
> # $FreeBSD: src/etc/periodic/daily/210.backup-aliases,v 1.6.36.1.2.1
> 2009/10/25 01:10:29 kensmith Exp $
> #
>
> # If there is a global system configuration file, suck it in.
> #
> if [ -r /etc/defaults/periodic.conf ]
> then
> =A0 =A0. /etc/defaults/periodic.conf
> =A0 =A0source_periodic_confs
> fi
>
> bak=3D/var/backups
> db_loc=3D$(/usr/bin/make -f/usr/share/mk/bsd.port.mk -V PKG_DBDIR 2>/dev/=
null)
> bk_loc=3D"$bak/pkgdb.bak.tar.bz2"
>
> case "$daily_backup_pkgdb_enable" in
> =A0 =A0[Yy][Ee][Ss])

This could be done via rc.subr's checkyesno function.

> =A0 =A0 =A0 =A0if [ ! -d $db_loc ]

Please quote the string.

> =A0 =A0 =A0 =A0then
> =A0 =A0 =A0 =A0 =A0 =A0echo '$daily_backup_pkgdb_enable is enabled but' \
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"$db_loc doesn't exist"
> =A0 =A0 =A0 =A0 =A0 =A0rc=3D2
> =A0 =A0 =A0 =A0else
> =A0 =A0 =A0 =A0 =A0 =A0rc=3D0
>
> =A0 =A0 =A0 =A0 =A0 =A0echo ""
> =A0 =A0 =A0 =A0 =A0 =A0echo "Backing up package db directory:"
>
> =A0 =A0 =A0 =A0 =A0 =A0[ -e $bk_loc ] && unlink $bk_loc

Please quote.

> =A0 =A0 =A0 =A0 =A0 =A0tar -cjf $bk_loc $db_loc || rc=3D3

Same here.

> =A0 =A0 =A0 =A0fi;;
>
> =A0 =A0*) =A0rc=3D0;;
> esac
>
> exit $rc

Thanks,
-Garrett



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?j2p7d6fde3d1004251944x8776db97z1482f6cb10e1ea64>