Date: Fri, 8 Nov 2019 13:51:18 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Colin Percival <cperciva@tarsnap.com>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r354482 - head/sys/x86/x86 Message-ID: <1d4ff16f-2c0c-8939-4876-4ceb0044d359@FreeBSD.org> In-Reply-To: <0100016e47e589be-1ed635b1-6701-43a8-88f7-79726e4bc036-000000@email.amazonses.com> References: <201911072114.xA7LExVP090362@repo.freebsd.org> <0100016e47bc3e05-560c061d-ef2e-41b1-9166-20d80cb6b81d-000000@email.amazonses.com> <69cbaec6-5799-9640-89bd-bdb5b6ae9843@FreeBSD.org> <0100016e47e589be-1ed635b1-6701-43a8-88f7-79726e4bc036-000000@email.amazonses.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08/11/2019 00:04, Colin Percival wrote: > On 2019-11-07 13:34, Andriy Gapon wrote: >> On 07/11/2019 23:19, Colin Percival wrote: >>> On 2019-11-07 13:14, Andriy Gapon wrote: >>>> x86 stack_save_td_running() can work safely only if IPI_TRACE is a >>>> non-maskable interrupt. But at the moment FreeBSD/Xen does not provide >>>> support for the NMI delivery mode. So, mark the functionality as >>>> unsupported similarly to other platforms without NMI. >>>> [...] >>>> +#ifdef XENHVM >>> >>> I'm not sure this does what you intended. XENHVM simply adds *support* for >>> running under Xen/HVM, and it's part of the GENERIC kernel. >> >> Oh... I should not have rushed. >> So, I should really check for a run-time Xen marker? > > I'm guessing that you want > > #include <sys/systm.h> > > ... > > if (vm_guest == VM_GUEST_XEN) > return (EOPNOTSUPP); > Colin, thank you again. But it seems that adding NMI support to a type of guest which is FreeBSD turned out to be much easier than I imagined. In fact, Roger (royger@) has already come up with a patch. I will be testing it soon. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1d4ff16f-2c0c-8939-4876-4ceb0044d359>