Date: Mon, 19 Jan 2009 10:05:35 +0100 From: Christoph Mallon <christoph.mallon@gmx.de> To: Bruce Evans <brde@optusnet.com.au> Cc: Stanislav Sedov <stas@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187396 - head/sys/gnu/fs/ext2fs Message-ID: <4974425F.5060600@gmx.de> In-Reply-To: <20090119192954.V37158@delplex.bde.org> References: <200901181454.n0IEskw4077045@svn.freebsd.org> <20090119192954.V37158@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans schrieb:
> On Sun, 18 Jan 2009, Stanislav Sedov wrote:
>
>> Log:
>> - Whitespace fixes.
>
> svn diff or a mailer always mangles whitespace (examples quoted below),
> so the whitespace fixes are hard to see in svn mail
[...]
>> @@ -5,7 +5,7 @@
>> * University of Utah, Department of Computer Science
>> */
>> /*-
>> - * Copyright (c) 1989, 1991, 1993, 1994
>> + * Copyright (c) 1989, 1991, 1993, 1994
>> * The Regents of the University of California. All rights reserved.
>> *
>> * Redistribution and use in source and binary forms, with or without
>> @@ -120,7 +120,7 @@ static int compute_sb_data(struct vnode
>> static const char *ext2_opts[] = { "from", "export", "acls", "noexec",
>> "noatime", "union", "suiddir", "multilabel", "nosymfollow",
>> "noclusterr", "noclusterw", "force", NULL };
>> -
>> +
>
> The above diff shows null changes, presumably after dropping trailing
> whitespace in the old version.
>
> Oops, actually the diff is invalid since something dropped the leading
> space in unchanged lines.
The diff in the original mail looks correct here: I see the removed
trailing whitespace in the - lines and the leading space in unchanged
lines. Your quoted version is "broken", so I suspect the problem is at
your end.
Christoph
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4974425F.5060600>