Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Apr 2026 14:59:44 +0000
From:      Christos Margiolis <christos@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 7793adfe72d3 - stable/15 - sound: Do not check for NULL before deleting ac97_info->methods
Message-ID:  <69f36e60.3da35.d1512de@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch stable/15 has been updated by christos:

URL: https://cgit.FreeBSD.org/src/commit/?id=7793adfe72d32b519f67e41b28683f929e6c8cb4

commit 7793adfe72d32b519f67e41b28683f929e6c8cb4
Author:     Christos Margiolis <christos@FreeBSD.org>
AuthorDate: 2026-04-18 10:33:58 +0000
Commit:     Christos Margiolis <christos@FreeBSD.org>
CommitDate: 2026-04-30 14:59:36 +0000

    sound: Do not check for NULL before deleting ac97_info->methods
    
    It is allocated with M_WAITOK in ac97_create().
    
    Sponsored by:   The FreeBSD Foundation
    MFC after:      1 week
    Pull Request:   https://ron-dev.freebsd.org/FreeBSD/src/pulls/17
    
    (cherry picked from commit aba2523261c1e541debe674c059c1ac16210fc04)
---
 sys/dev/sound/pcm/ac97.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sys/dev/sound/pcm/ac97.c b/sys/dev/sound/pcm/ac97.c
index 73a1e0280e56..1407d202a0d1 100644
--- a/sys/dev/sound/pcm/ac97.c
+++ b/sys/dev/sound/pcm/ac97.c
@@ -835,8 +835,7 @@ void
 ac97_destroy(struct ac97_info *codec)
 {
 	mtx_lock(&codec->lock);
-	if (codec->methods != NULL)
-		kobj_delete(codec->methods, M_AC97);
+	kobj_delete(codec->methods, M_AC97);
 	mtx_destroy(&codec->lock);
 	free(codec, M_AC97);
 }


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69f36e60.3da35.d1512de>