Date: Sat, 8 Nov 2003 11:04:23 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/contrib/gcc c-lex.c Message-ID: <20031108090423.GA54533@sunbay.com> In-Reply-To: <20031108194726.M674@gamplex.bde.org> References: <200311070330.hA73UWPR092624@repoman.freebsd.org> <200311070327.hA73RWjs092423@repoman.freebsd.org> <200311070309.hA739eRe091475@repoman.freebsd.org> <20031107084045.GD86943@sunbay.com> <20031108023113.Q4736@gamplex.bde.org> <20031107160744.GA47423@sunbay.com> <20031108194726.M674@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sat, Nov 08, 2003 at 07:55:31PM +1100, Bruce Evans wrote:
> On Fri, 7 Nov 2003, Ruslan Ermilov wrote:
>
> > On Sat, Nov 08, 2003 at 02:36:09AM +1100, Bruce Evans wrote:
> > > On Fri, 7 Nov 2003, Ruslan Ermilov wrote:
> > >
> > > > On Thu, Nov 06, 2003 at 07:09:40PM -0800, Alexander Kabaev wrote:
> > > > > kan 2003/11/06 19:09:40 PST
> > > > >
> > > > > FreeBSD src repository
> > > > >
> > > > > Modified files:
> > > > > contrib/gcc c-lex.c
> > > > > Log:
> > > > > Drop the revision 1.2 (don't let gcc(1) hide warnings in system headers)
> > > > > and use stock version of this file now.
> > > > > ...
> > > >
> > > > Will -Wsystem-headers from bsd.sys.mk for WARNS > 0 still take care
> > > > of emitting warnings in system headers?
> > >
> > > If WARNS > 0 it will :-). I think we have enough WARNS > 0 to catch
> > > most problems, but developers, especially bde and ru, should run with
> > > -Wsystem-headers unconditional in bsd.sys.mk.
> > >
> > I mean, does -Wsystem-headers affect both cc(1) and cpp(1) now?
>
> Yes, but I think your question is whether we enable it for cpp. We don't
> do anything except enable it in CFLAGS if WARNS > 0 AFAIK, so only
> invocations of cpp that use CFLAGS get it. This may be enough.
>
OK, I now recall -- there was no such thing like -Wsystem-headers
in 2.95.x and probably 3.0, where these local mods were originally
made, and I now see that it affects both cpp(1) and gcc(1), thanks.
My main concern, as I already told you in private, is to keep
buildworld and "make all" types of builds consistent; previously,
buildworld used the ``-nostdinc -I${WORLDTMP}/usr/include'' hack,
that caused harm in this area (system headers were not treated
as system), now that this hack is gone, I'm happy. ;-)
Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software Ltd,
ru@FreeBSD.org FreeBSD committer
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
iD8DBQE/rLGXUkv4P6juNwoRAqByAJ9CmKk3HJJWpYoL9kADIo59UOWhCACfZ6+E
E1dFo9ToN3gGsXm0LNyH9WA=
=W+9h
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031108090423.GA54533>