Date: Thu, 27 Oct 1994 23:44:07 -0700 (PDT) From: Rodney W Grimes <rgrimes@ref.tfs.com> To: jkh@freefall.cdrom.com (Jordan K. Hubbard) Cc: ache@astral.msk.su, CVS-commiters@freefall.cdrom.com, cvs-gnu@freefall.cdrom.com, rgrimes@freefall.cdrom.com Subject: Re: cvs commit: src/gnu/lib/libdialog Makefile Message-ID: <199410280644.XAA00704@ref.tfs.com> In-Reply-To: <6736.783326078@freefall.cdrom.com> from "Jordan K. Hubbard" at Oct 27, 94 11:34:38 pm
next in thread | previous in thread | raw e-mail | index | archive | help
> > > Please back out this change. It is intended to do so. > > Proper way is 'make beforeinstall'. I've got flamewar with Rod > > on this subject long time ago (libcurses 1.1.5.1), I plan to > > Then Rod is wrong. Anything that causes a simple `make' to fall over > after someone's supped the tree is indefensible. Now we're going to > have all these magic directories where you have to know to do a `make > beforeinstall' before your make worlds can progress through? People > have to perturb their install areas just to compile things ? No, > that's just utterly bogus. I can't believe that Rod was arguing for > this, since he's often very hard come down on stuff where the > build/install line was blurry, and it hosed us. cd /usr/src; make includes calls all the beforeinstall rules for you, this is often left out by people running what they are claiming to be a ``make world'' but if you leave this step out you get the failers you have seen. Andrew misunderstood what the gripe about the -I${.CURDIR} and what he had done in the Makefile. I never objected to that, I objected to the fact that there was no beforeinstall to do the .h files, and that src/Makefile was not calling it during make includes. Next person I read about a make world failing over that was caused by a failure to really run a ``make world'' who claims to have run make world is going to get a shutgun full of my yelling.... :-). Either run ``make world'' or make damn sure you do every thing it would have done for you.. no short cuts allowed! [I also higly recommend a rm -r of /usr/include once a week :-)] > Jordan -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199410280644.XAA00704>