Date: Mon, 11 May 2009 18:45:04 +0000 (UTC) From: Rick Macklem <rmacklem@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r191998 - head/sys/fs/nfsserver Message-ID: <200905111845.n4BIj4gV099122@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: rmacklem Date: Mon May 11 18:45:04 2009 New Revision: 191998 URL: http://svn.freebsd.org/changeset/base/191998 Log: Modify nfsvno_fhtovp() to ensure that it always sets the credp argument. Returning without credp set could result in a caller doing crfree() on garbage. Reviewed by: kan Approved by: kib (mentor) Modified: head/sys/fs/nfsserver/nfs_nfsdport.c Modified: head/sys/fs/nfsserver/nfs_nfsdport.c ============================================================================== --- head/sys/fs/nfsserver/nfs_nfsdport.c Mon May 11 18:20:34 2009 (r191997) +++ head/sys/fs/nfsserver/nfs_nfsdport.c Mon May 11 18:45:04 2009 (r191998) @@ -2422,6 +2422,7 @@ nfsvno_fhtovp(struct mount *mp, fhandle_ int error; int numsecflavor, *secflavors; + *credp = NULL; error = VFS_FHTOVP(mp, &fhp->fh_fid, vpp); if (nam && !error) { error = VFS_CHECKEXP(mp, nam, &exp->nes_exflag, credp,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905111845.n4BIj4gV099122>