Date: Sat, 14 Nov 2015 00:00:30 +0000 From: Steven Hartland <steven.hartland@multiplay.co.uk> To: Gleb Smirnoff <glebius@FreeBSD.org>, "Alexander V. Chernikov" <melifaro@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290603 - in head/sys: net netgraph netinet Message-ID: <5646799E.3030806@multiplay.co.uk> In-Reply-To: <20151113225400.GE73031@FreeBSD.org> References: <201511091011.tA9ABFWb029549@repo.freebsd.org> <20151113225400.GE73031@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
On 13/11/2015 22:54, Gleb Smirnoff wrote: > Alexander, > > On Mon, Nov 09, 2015 at 10:11:15AM +0000, Alexander V. Chernikov wrote: > A> Author: melifaro > A> Date: Mon Nov 9 10:11:14 2015 > A> New Revision: 290603 > A> URL: https://svnweb.freebsd.org/changeset/base/290603 > A> > A> Log: > A> Use lladdr_event to propagate gratiotus arp. > A> > A> Differential Revision: https://reviews.freebsd.org/D4019 > > Looking into a diff a lame question emerges: why can't the call > to EVENTHANDLER_INVOKE() moved right into the end of the > if_setlladdr()? > This would indeed be a good change, not only does it eliminate duplicate code, simplifying things but it also ensures the event is fired if more callers are added. Regards Stevehome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5646799E.3030806>