Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Jan 2017 18:35:24 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r312993 - head/contrib/llvm/lib/Transforms/Scalar
Message-ID:  <201701301835.v0UIZOhO005211@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dim
Date: Mon Jan 30 18:35:24 2017
New Revision: 312993
URL: https://svnweb.freebsd.org/changeset/base/312993

Log:
  Pull in r279454 from upstream llvm trunk (by James Molloy):
  
    [SROA] Remove incorrect assertion
  
    Confirmed with aprantl, this assertion is incorrect - code can get
    here (for example 80-bit FP types) and if it does it's benign. This
    is exposed by a completely unrelated patch of mine, so stop the
    compiler falling over.
  
    Original differential: http://reviews.llvm.org/D16187
    aprantl's advice to remove assertion:
    http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20160815/382129.html
  
  This should fix assertions when building the math/opensolaris-libm port.
  
  Reported by:	marino
  MFC after:	3 days

Modified:
  head/contrib/llvm/lib/Transforms/Scalar/SROA.cpp

Modified: head/contrib/llvm/lib/Transforms/Scalar/SROA.cpp
==============================================================================
--- head/contrib/llvm/lib/Transforms/Scalar/SROA.cpp	Mon Jan 30 16:32:53 2017	(r312992)
+++ head/contrib/llvm/lib/Transforms/Scalar/SROA.cpp	Mon Jan 30 18:35:24 2017	(r312993)
@@ -4040,9 +4040,6 @@ bool SROA::splitAlloca(AllocaInst &AI, A
           Size = std::min(Size, AbsEnd - Start);
         }
         PieceExpr = DIB.createBitPieceExpression(Start, Size);
-      } else {
-        assert(Pieces.size() == 1 &&
-               "partition is as large as original alloca");
       }
 
       // Remove any existing dbg.declare intrinsic describing the same alloca.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701301835.v0UIZOhO005211>