Skip site navigation (1)Skip section navigation (2) 
Date:      Sun, 6 May 2018 16:22:03 +0000 (UTC)
From:      Sean Bruno <sbruno@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r333307 - head/cddl/contrib/opensolaris/lib/libzfs/common
Message-ID:  <201805061622.w46GM39L061892@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: sbruno
Date: Sun May  6 16:22:02 2018
New Revision: 333307
URL: https://svnweb.freebsd.org/changeset/base/333307

Log:
  Cleanup sundry clang warnings for code that is not upstream in illumos.
  https://github.com/illumos/illumos-gate/edit/master/usr/src/lib/libzfs/common/libzfs_sendrecv.c
  
  Patch our version of it to quiesce warnings until someone decides to sync
  up our code:
  
  libzfs_sendrecv.c:2555:30: warning: format specifies type 'unsigned long'
    but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat]
                                  sprintf(guidname, "%lu", thisguid);
                                                     ~~~   ^~~~~~~~
                                                     %llu
  libzfs_sendrecv.c:2612:29: warning: format specifies type 'unsigned long'
    but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat]
                          sprintf(guidname, "%lu", parent_fromsnap_guid);
                                             ~~~   ^~~~~~~~~~~~~~~~~~~~
                                             %llu
  libzfs_sendrecv.c:2645:29: warning: format specifies type 'unsigned long'
    but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat]
                          sprintf(guidname, "%lu", parent_fromsnap_guid);
                                             ~~~   ^~~~~~~~~~~~~~~~~~~~
                                             %llu
  
  Reviewed by:	allanjude
  Differential Revision:	https://reviews.freebsd.org/D15325

Modified:
  head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_sendrecv.c

Modified: head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_sendrecv.c
==============================================================================
--- head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_sendrecv.c	Sun May  6 15:59:03 2018	(r333306)
+++ head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_sendrecv.c	Sun May  6 16:22:02 2018	(r333307)
@@ -2552,7 +2552,7 @@ again:
 					needagain = B_TRUE;
 				else
 					progress = B_TRUE;
-				sprintf(guidname, "%lu", thisguid);
+				sprintf(guidname, "%" PRIu64, thisguid);
 				nvlist_add_boolean(deleted, guidname);
 				continue;
 			}
@@ -2609,7 +2609,7 @@ again:
 				needagain = B_TRUE;
 			else
 				progress = B_TRUE;
-			sprintf(guidname, "%lu", parent_fromsnap_guid);
+			sprintf(guidname, "%" PRIu64, parent_fromsnap_guid);
 			nvlist_add_boolean(deleted, guidname);
 			continue;
 		}
@@ -2642,7 +2642,7 @@ again:
 		if (stream_parent_fromsnap_guid != 0 &&
                     parent_fromsnap_guid != 0 &&
                     stream_parent_fromsnap_guid != parent_fromsnap_guid) {
-			sprintf(guidname, "%lu", parent_fromsnap_guid);
+			sprintf(guidname, "%" PRIu64, parent_fromsnap_guid);
 			if (nvlist_exists(deleted, guidname)) {
 				progress = B_TRUE;
 				needagain = B_TRUE;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805061622.w46GM39L061892>