Date: Wed, 8 Mar 2017 09:37:37 -0800 From: Luigi Rizzo <rizzo@iet.unipi.it> To: Sean Bruno <sbruno@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r314915 - head/tools/tools/netmap Message-ID: <CA%2BhQ2%2Bjm-G3z7No_8YnHTcYxEOR8bGM3U%2BvspUj8LHCTGbCQ3A@mail.gmail.com> In-Reply-To: <201703081729.v28HTekF062971@repo.freebsd.org> References: <201703081729.v28HTekF062971@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 8, 2017 at 9:29 AM, Sean Bruno <sbruno@freebsd.org> wrote: > Author: sbruno > Date: Wed Mar 8 17:29:40 2017 > New Revision: 314915 > URL: https://svnweb.freebsd.org/changeset/base/314915 > > Log: > Use the buildworld includes and defaults when building pkt-gen. This will > mean that you need a world built to reliably build pkg-gen but this keeps > the build from failing when your source doesn't match your host running > version, e.g. building 12 on 11. This is a good change, but maybe it could help to leave a comment like the following one in the Makefile: # Some netmap helper functions are in sys/net/netmap_user.h. # To build applications using the headers in the source tree, use # make CFLAGS="-nostdinc -I ../../../sys -I/usr/include" ... This is because netmap does not have a proper support library, but some minimal helper functions in netmap_user.h , and people may want to override them. cheers luigi > > Submitted by: Matt Macy <mmacy@nextbsd.org> > MFC after: 2 weeks > Sponsored by: Limelight Networks > > Modified: > head/tools/tools/netmap/Makefile > > Modified: head/tools/tools/netmap/Makefile > ============================================================================== > --- head/tools/tools/netmap/Makefile Wed Mar 8 14:52:03 2017 (r314914) > +++ head/tools/tools/netmap/Makefile Wed Mar 8 17:29:40 2017 (r314915) > @@ -8,7 +8,6 @@ PROGS = pkt-gen nmreplay bridge vale-ctl > CLEANFILES = $(PROGS) *.o > MAN= > CFLAGS += -Werror -Wall > -CFLAGS += -nostdinc -I ../../../sys -I/usr/include > CFLAGS += -Wextra > > LDFLAGS += -lpthread > -- -----------------------------------------+------------------------------- Prof. Luigi RIZZO, rizzo@iet.unipi.it . Dip. di Ing. dell'Informazione http://www.iet.unipi.it/~luigi/ . Universita` di Pisa TEL +39-050-2217533 . via Diotisalvi 2 Mobile +39-338-6809875 . 56122 PISA (Italy) -----------------------------------------+-------------------------------
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BhQ2%2Bjm-G3z7No_8YnHTcYxEOR8bGM3U%2BvspUj8LHCTGbCQ3A>