Date: Fri, 31 Oct 2014 17:54:07 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI <delphij@FreeBSD.org> Subject: Re: svn commit: r273919 - head/etc/rc.d Message-ID: <0577B462-91E9-4E46-BF9E-085B50EDE09C@gmail.com> In-Reply-To: <86bnor9202.fsf@nine.des.no> References: <201410312220.s9VMKRaO096404@svn.freebsd.org> <86bnor9202.fsf@nine.des.no>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Oct 31, 2014, at 17:51, Dag-Erling Smørgrav <des@des.no> wrote: > Xin LI <delphij@FreeBSD.org> writes: >> Log: >> rc.d/geli should not depend on random, as the attach functionality >> do not require additional entropy to function. >> >> It would create a circular dependency (not immediately obvious: >> geli provides 'disks' and requires 'random' as of r273872, >> 'random' requires 'FILESYSTEMS', 'FILESYSTEMS' requires 'root', >> 'root' requires 'swap', and finally 'swap' requires 'disk'). > > My first instinct was: shouldn't rcorder warn about this? It turns out > that it does, but in a very cryptic fashion: > > des@nine ~head/etc/rc.d% svn up -qr273871 > des@nine ~head/etc/rc.d% rcorder * >/dev/null > des@nine ~head/etc/rc.d% svn up -qr273872 > des@nine ~head/etc/rc.d% rcorder * >/dev/null > rcorder: Circular dependency on file `zfs'. > rcorder: Circular dependency on provision `mountcritlocal' in file `zfs'. > rcorder: Circular dependency on provision `mountcritlocal' in file `var'. > rcorder: Circular dependency on provision `mountcritlocal' in file `FILESYSTEMS'. > rcorder: Circular dependency on provision `root' in file `FILESYSTEMS'. > des@nine ~head/etc/rc.d% svn up -qr273919 > des@nine ~head/etc/rc.d% rcorder * >/dev/null > des@nine ~head/etc/rc.d% rcorder errors are indeed cryptic/confusing. I can quickly add a testcase for this if you like (basically check for all the scenarios that need to be covered via /etc/rc). Does that sound good? Thanks! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUVC8vAAoJEMZr5QU6S73eH4AH/0x96qlsz3AdSPeCxTjNU1cE 7xJPuln401K/ORTt28vnzyw8uPQ2ldvfzqmwuR5ijSl3o1lW/jMWMPbwCuSkFP2w xgviOSsqzdqhPifOb5VCoRP95kuCyq9+k9Cdrs9Q3jlC7ijBAla7cxYCGtRK2xQW qgVI4v/a+/P1Q+rHS2XC5fh9qBXUH/U7Ybq5CrAfPCh57BpUfWtArmYHyGubcDew m/c172ERAiG035IJeTdoBC/dX2NMCOwQiy3wxNkSq7OCMeLirv04GK5tOOZIHaaZ HXPBcyFQfAtB5ugILC4/rjIWznaTMZg3+n6WdJs6643fJ2qLCeSHlHlmhjohoZY= =AsJe -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0577B462-91E9-4E46-BF9E-085B50EDE09C>