Date: Tue, 3 Feb 2015 17:21:43 +0000 From: "adrian (Adrian Chadd)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] [Updated] D1761: Extend LRO support to accumulate more than 65535 bytes Message-ID: <64d310e88308f1595c3535292bba0a65@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-wifan4aus5qtbwh2gnxc-req@FreeBSD.org> References: <differential-rev-PHID-DREV-wifan4aus5qtbwh2gnxc-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
adrian added a comment. Hi, My main concern with this patch is the special casing of what is the "packet length" being sprinkled all throughout the code. It feels like we could be chasing down obscure "is this the right length for this kind of packet" bugs for quite some time. Is there any way we could unify this stuff a bit? I'm open to ideas. REVISION DETAIL https://reviews.freebsd.org/D1761 To: hselasky, rmacklem, rrs, glebius, gnn, emaste, bz, rwatson, imp, adrian Cc: freebsd-net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?64d310e88308f1595c3535292bba0a65>