Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Dec 2016 15:26:28 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Roman Bogorodskiy <bogorodskiy@gmail.com>
Cc:        Roman Bogorodskiy <novel@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, alexander.nusov@nfvexpress.com
Subject:   Re: svn commit: r428845 - in head/devel: . py-XStatic py-XStatic-Angular py-XStatic-Angular-Bootstrap py-XStatic-Angular-FileUpload py-XStatic-Angular-Gettext py-XStatic-Angular-Schema-Form py-XStatic-...
Message-ID:  <c689af30-28b1-b321-12c6-96d5d5c00b68@FreeBSD.org>
In-Reply-To: <20161218135215.GA48900@kloomba>
References:  <201612181136.uBIBaQLG037821@repo.freebsd.org> <56123f95-c5dc-1e3a-3db5-d87043949c45@FreeBSD.org> <20161218135215.GA48900@kloomba>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--fsH1SjHdFsK7riIjs2QOAoV9puFEu9H1P
Content-Type: multipart/mixed; boundary="rjclJLskcttRsFMWhscfhJ5ASWdEu9iqU";
 protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: Roman Bogorodskiy <bogorodskiy@gmail.com>
Cc: Roman Bogorodskiy <novel@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org,
 alexander.nusov@nfvexpress.com
Message-ID: <c689af30-28b1-b321-12c6-96d5d5c00b68@FreeBSD.org>
Subject: Re: svn commit: r428845 - in head/devel: . py-XStatic
 py-XStatic-Angular py-XStatic-Angular-Bootstrap py-XStatic-Angular-FileUpload
 py-XStatic-Angular-Gettext py-XStatic-Angular-Schema-Form py-XStatic-...
References: <201612181136.uBIBaQLG037821@repo.freebsd.org>
 <56123f95-c5dc-1e3a-3db5-d87043949c45@FreeBSD.org>
 <20161218135215.GA48900@kloomba>
In-Reply-To: <20161218135215.GA48900@kloomba>

--rjclJLskcttRsFMWhscfhJ5ASWdEu9iqU
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Le 18/12/2016 =C3=A0 14:52, Roman Bogorodskiy a =C3=A9crit :
>   Mathieu Arnold wrote:
>
>> Le 18/12/2016 =C3=A0 12:36, Roman Bogorodskiy a =C3=A9crit :
>>> +COMMENT=3D	Xstatic-angular-bootstrap
>>>
>>> Added: head/devel/py-XStatic-Angular-Bootstrap/pkg-descr
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>>> +++ head/devel/py-XStatic-Angular-Bootstrap/pkg-descr	Sun Dec 18 11:3=
6:26 2016	(r428845)
>>> @@ -0,0 +1,3 @@
>>> +XStatic-Angular-Bootstrap
>>> +
>>> +WWW: http://pypi.python.org/pypi/XStatic-Angular-Bootstrap
>>> +COMMENT=3D	Angular-fileupload 12.0.4 (xstatic packaging standard)
>>>
>>> Added: head/devel/py-XStatic-Angular-FileUpload/pkg-descr
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>>> +++ head/devel/py-XStatic-Angular-FileUpload/pkg-descr	Sun Dec 18 11:=
36:26 2016	(r428845)
>>> @@ -0,0 +1,3 @@
>>> +Angular-FileUpload 12.0.4 (XStatic packaging standard)
>>> +
>>> +WWW: http://pypi.python.org/pypi/XStatic-Angular-FileUpload
>> ...
>>
>> I understand those were mechanically created, but all the COMMENT[1] a=
nd
>> pkg-descr[2] files fall very short of our requirements.
>>
>> 1:
>> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-comment=
=2Ehtml
>>
>> 2: https://www.freebsd.org/doc/en/books/porters-handbook/porting-desc.=
html
> This is generally an information obtained from the corresponding Python=

> packages. E.g. for XStatic-Angular-FileUpload we only have:

Let me quote one of the rules for COMMENT:

2) Do not include the package name or version number of software.

The fact that python does not enforce rules on their packages does not
mean we do not.

> We probably can add README contents to pkg-descr (I'm not sure it bring=
s
> a lot of value though, it looks likes it's more or less common for thes=
e
> packages with only package name changed), but I'm not sure how can we
> improve COMMENT.

Please read the handbook links I gave you. COMMENT is a short, one line,
description of the software. pkg-descr is a longer description, it
should tell me what does, what it is, why it is usefull.
Especially, I should not have to go to the web site to understand those
things.


--=20
Mathieu Arnold



--rjclJLskcttRsFMWhscfhJ5ASWdEu9iqU--

--fsH1SjHdFsK7riIjs2QOAoV9puFEu9H1P
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQJ8BAEBCgBmBQJYVpyVXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85ImZIP/0bKI3Qy8/YECJ4kBfeolk/P
L1CsYn/pUTO+yPm3QmiErw112ld6yeU0GiLNl+ZuyAOPkWWOm8VOK/81OfeC1Yvz
VNequkKXHZTgPvEgiL5QlTl8ck9JAFsGx6UW+c/ahROKKmQcADD0EdfNaHcUHrnG
S5fSBLK80la5htdPifCIiySa5Ob0mXOfw2bUbRX05pD0M6TWuri4KegUQGm7arQw
wCh8eMqTM10aqfCRnP3TmXIKsKX5nWunvRYK50Es6adx3HvrnHE7JtGOZZO8mtpt
NbPDu8mCEnUCN32Z54mDAMPCbgLad4xaXSxFWyyjaHGNdx5CTN+ieJZhgjPIYHzD
ibLjXMJNP2fMrPlxLppgkiAR1pvtGk1Ggp+HKxz5ggnooawCgdCi2RTkfW5FHDsB
twPDmHk+CQ0vNBLoMmuLY87RbSEP5k1NhnXIe6qARm+rZmqbFriMYw2yXKqhqMv5
iM+Gc8nS5xMykj8BLwLx1GgCUyZnZrzz07r9bvI/6pvVA+/e4x5aXeHsJgFkA6In
x0Mng96+oZM21Pac52iJRhPOpKt+88FTt6w9Q6gz5TaZPPnanZqqa5rjWALkhowd
c/NeAMpQR+NOPbwUnguSqzSkDizwJw4ijXf2Iq9M9OwCmcKmlJMALLimNuViYolI
oHJtbI51o1AICu/ytnGP
=XHmh
-----END PGP SIGNATURE-----

--fsH1SjHdFsK7riIjs2QOAoV9puFEu9H1P--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c689af30-28b1-b321-12c6-96d5d5c00b68>