Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Oct 2022 13:38:44 -0600
From:      Adam Weinberger <adamw@freebsd.org>
To:        Piotr Kubaj <pkubaj@anongoth.pl>
Cc:        Adam Weinberger <adamw@freebsd.org>, ports-committers@freebsd.org,  dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 9d241a90370c - main - Mk: Add USES=luajit
Message-ID:  <CAP7rwcjxYq4eXERQeKM%2BrDjEWZz_qQW8rPKwFC=iUZDyHQFd-g@mail.gmail.com>
In-Reply-To: <Y0m5tT6gRZ0aalYJ@KGPE-D16>
References:  <202210141707.29EH7i08013647@gitrepo.freebsd.org> <Y0mxWT01SkaxD3n/@KGPE-D16> <CAP7rwciL%2BY9d-8Cg9yVyL0sMDRi_4rpnEG5PUKu=twmwfZo-MA@mail.gmail.com> <Y0m5tT6gRZ0aalYJ@KGPE-D16>

next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000000d3aaf05eb03c7c6
Content-Type: text/plain; charset="UTF-8"

On Fri, Oct 14, 2022 at 1:34 PM Piotr Kubaj <pkubaj@anongoth.pl> wrote:

> On 22-10-14 13:01:25, Adam Weinberger wrote:
> >On Fri, Oct 14, 2022 at 12:58 PM Piotr Kubaj <pkubaj@anongoth.pl> wrote:
> >
> >> On 22-10-14 17:07:44, Adam Weinberger wrote:
> >> >The branch main has been updated by adamw:
> >> >
> >> >URL:
> >>
> https://cgit.FreeBSD.org/ports/commit/?id=9d241a90370c9410d997be37db5e3a5657bdb4ca
> >> >
> >> >commit 9d241a90370c9410d997be37db5e3a5657bdb4ca
> >> >Author:     Adam Weinberger <adamw@FreeBSD.org>
> >> >AuthorDate: 2022-10-14 16:50:39 +0000
> >> >Commit:     Adam Weinberger <adamw@FreeBSD.org>
> >> >CommitDate: 2022-10-14 17:07:39 +0000
> >> >
> >> >    Mk: Add USES=luajit
> >> >
> >> >    USES=luajit centralizes luajit dependencies via
> >> bsd.default-versions.mk
> >> >    (defaulting to luajit-devel).
> >> >
> >> >    Ports currently depend on:
> >> >      lang/luajit: 42
> >> >      lang/luajit-devel: 0
> >> >      lang/luajit-openresty: 51
> >> >
> >> >    The difficulty here is that:
> >> >      - They all conflict with each other
> >> >      - Upstream is very clear about not intending for users to use the
> >> >        version in lang/luajit at all, and wants all luajit users to
> use
> >> >        lang/luajit-devel
> >> >      - luajit-openresty is very aggressive about being drop-in
> compatible
> >> >        with luajit-devel (though not the other direction)
> >> >
> >> >    For the vast majority of situations, USES=luajit will be
> sufficient.
> >> >    Ports that use openresty's API additions can specify
> >> >    USES=luajit:openresty.
> >> >
> >> >    I'm adding this into head very early in the 2022Q4 cycle so that
> >> there's
> >> >    ample time to address the default. It's a difficult decision. osa,
> the
> >> >    maintainer of luajit and luajit-devel, prefers that the default be
> >> >    luajit, but I went the other direction because it's in direct
> conflict
> >> >    with upstream's clear stated intention. It's not a simple decision;
> >> see
> >> >    the review below for a little discussion on it.
> >> >
> >> >    The TL;DR here is that this defaults to the one luajit version
> that no
> >> >    port currently depends on. However, this version is what OpenBSD,
> >> >    Homebrew, Ubuntu, Debian, Fedora, MacPorts, and Arch default to
> (and
> >> >    none of them even provide the stale version lang/luajit provides).
> >> >    This will bring FreeBSD in line with nearly every other OS package
> >> >    system, and with upstream's intention.
> >> >
> >> >    See also PRs 225342, 257051.
> >> >
> >> >    Reviewed by:    bapt, tcberner
> >> >    Approved by:    portmgr (bapt, tcberner)
> >> >    Differential Revision:  https://reviews.freebsd.org/D36947
> >> >---
> >> > Mk/Uses/luajit.mk          | 27 +++++++++++++++++++++++++++
> >> > Mk/bsd.default-versions.mk |  9 ++++++---
> >> > 2 files changed, 33 insertions(+), 3 deletions(-)
> >> >
> >> >diff --git a/Mk/Uses/luajit.mk b/Mk/Uses/luajit.mk
> >> >new file mode 100644
> >> >index 000000000000..75e54407d484
> >> >--- /dev/null
> >> >+++ b/Mk/Uses/luajit.mk
> >> >@@ -0,0 +1,27 @@
> >> >+# Select your favorite luajit runtime
> >> >+# Feature:    luajit
> >> >+# Usage:      USES=  luajit[:version]
> >> >+# MAINTAINER: adamw@FreeBSD.org
> >> >+
> >> >+.if !defined(_INCLUDE_USES_LUAJIT_MK)
> >> >+_INCLUDE_USES_LUAJIT_MK=yes
> >> >+
> >> >+.if !empty(luajit_ARGS)
> >> >+LUAJIT_VER=   ${luajit_ARGS}
> >> >+.else
> >> >+LUAJIT_VER=   ${LUAJIT_DEFAULT}
> >> >+.endif
> >> >+
> >> >+# When adding a version, please keep the comment in
> >> >+# Mk/bsd.default-versions.mk in sync
> >> >+VALID_LUAJIT_VER=     luajit luajit-devel luajit-openresty
> >> >+
> >> >+.if empty(VALID_LUAJIT_VER:M${LUAJIT_DEFAULT})
> >> >+IGNORE=       Invalid luajit default version ${LUAJIT_DEFAULT}: valid
> >> versions are ${VALID_LUAJIT_VER}
> >> >+.elif empty(VALID_LUAJIT_VER:M${LUAJIT_VER})
> >> >+IGNORE=       Invalid luajit version ${LUAJIT_VER}: valid versions are
> >> ${VALID_LUAJIT_VER}
> >> >+.endif
> >> >+
> >> >+LIB_DEPENDS=  libluajit-5.1.so:lang/${LUAJIT_VER}
> >> >+
> >> >+.endif
> >> >diff --git a/Mk/bsd.default-versions.mk b/Mk/bsd.default-versions.mk
> >> >index bbf3d5880c70..5a36e0b9c4d0 100644
> >> >--- a/Mk/bsd.default-versions.mk
> >> >+++ b/Mk/bsd.default-versions.mk
> >> >@@ -17,9 +17,10 @@ _INCLUDE_BSD_DEFAULT_VERSIONS_MK=   yes
> >> >
> >> > LOCALBASE?=   /usr/local
> >> >
> >> >-.  for lang in APACHE BDB COROSYNC EMACS FIREBIRD FORTRAN FPC GCC
> >> GHOSTSCRIPT GL GO \
> >> >-      IMAGEMAGICK JAVA LAZARUS LIBRSVG2 LINUX LLVM LUA MONO MYSQL
> NINJA
> >> NODEJS PERL5 \
> >> >-      PGSQL PHP PYTHON PYTHON2 PYTHON3 RUBY RUST SAMBA SSL TCLTK
> VARNISH
> >> >+.  for lang in APACHE BDB COROSYNC EMACS FIREBIRD FORTRAN FPC GCC \
> >> >+      GHOSTSCRIPT GL GO IMAGEMAGICK JAVA LAZARUS LIBRSVG2 LINUX LLVM \
> >> >+      LUA LUAJIT MONO MYSQL NINJA NODEJS PERL5 PGSQL PHP PYTHON \
> >> >+      PYTHON2 PYTHON3 RUBY RUST SAMBA SSL TCLTK VARNISH
> >> > .    if defined(${lang}_DEFAULT)
> >> > ERROR+=       "The variable ${lang}_DEFAULT is set and it should only
> be
> >> defined through DEFAULT_VERSIONS+=${lang:tl}=${${lang}_DEFAULT} in
> >> /etc/make.conf"
> >> > .    endif
> >> >@@ -86,6 +87,8 @@ LLVM_DEFAULT?=               90
> >> > .  endif
> >> > # Possible values: 5.1, 5.2, 5.3, 5.4
> >> > LUA_DEFAULT?=         5.2
> >> >+# Possible values: luajit, luajit-devel, luajit-openresty
> >> >+LUAJIT_DEFAULT?=      luajit-devel
> >> > # Possible values: 5.10, 5.20, 6.8
> >> > MONO_DEFAULT=         5.10
> >> > # Possible values: 5.6, 5.7, 8.0, 10.3m, 10.4m, 10.5m, 5.7p, 5.7w
> >>
> >> Could you make USES=luajit default to openresty on powerpc64 and
> >> powerpc64le? lang/luajit and lang/luajit-devel don't support those, but
> >> openresty fork does.
> >>
> >> I believe aarch64 is in similar situation, except that it's also
> >> supported by luajit-devel.
> >>
> >
> >Are you positive on that? luajit-devel just has IGNORE_riscv64 (which no
> >luajit works on), and includes a block specifically for powerpc*.
> It was originally added in
>
> https://cgit.freebsd.org/ports/commit/lang/luajit/Makefile?id=d2ac3fee9c894bb6f10ab489a4b165f974fc1b03
> .
> The review (at https://reviews.freebsd.org/D13804) says:
> Successfully built on powerpc. Does not build for powerpc64, though.
> Later, that was copied to luajit-devel.
> Here's the most recent build on powerpc64le:
>
> https://talos.anongoth.pl/data/latest-per-pkg/luajit-devel/2.1.0.20220815/powerpc64le-default.log
> So that:
> .if ${ARCH:Mpowerpc*} || ${ARCH:Mmips*} || ${ARCH:Msparc*}
> can be replaced by just:
> .if ${ARCH} == powerpc || ${ARCH} == powerpcspe
>
> If you wish, the mips* and sparc64 parts can be added too, but I don't
> think there are any users left.
>

Thank you!!

I'll put a test for ${ARCH:Mpowerpc64*} in bsd.default-versions.mk.

# Adam



>
> >
> ># Adam
> >
> >
> >--
> >Adam Weinberger
> >adamw@adamw.org // adamw@FreeBSD.org
> >https://www.adamw.org
>


-- 
Adam Weinberger
adamw@adamw.org // adamw@FreeBSD.org
https://www.adamw.org

--0000000000000d3aaf05eb03c7c6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:arial,sans-serif"><br></div></div><br><div class=3D"gmail_quote"><=
div dir=3D"ltr" class=3D"gmail_attr">On Fri, Oct 14, 2022 at 1:34 PM Piotr =
Kubaj &lt;<a href=3D"mailto:pkubaj@anongoth.pl">pkubaj@anongoth.pl</a>&gt; =
wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 22-10-=
14 13:01:25, Adam Weinberger wrote:<br>
&gt;On Fri, Oct 14, 2022 at 12:58 PM Piotr Kubaj &lt;<a href=3D"mailto:pkub=
aj@anongoth.pl" target=3D"_blank">pkubaj@anongoth.pl</a>&gt; wrote:<br>
&gt;<br>
&gt;&gt; On 22-10-14 17:07:44, Adam Weinberger wrote:<br>
&gt;&gt; &gt;The branch main has been updated by adamw:<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;URL:<br>
&gt;&gt; <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D9d241a90370=
c9410d997be37db5e3a5657bdb4ca" rel=3D"noreferrer" target=3D"_blank">https:/=
/cgit.FreeBSD.org/ports/commit/?id=3D9d241a90370c9410d997be37db5e3a5657bdb4=
ca</a><br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;commit 9d241a90370c9410d997be37db5e3a5657bdb4ca<br>
&gt;&gt; &gt;Author:=C2=A0 =C2=A0 =C2=A0Adam Weinberger &lt;adamw@FreeBSD.o=
rg&gt;<br>
&gt;&gt; &gt;AuthorDate: 2022-10-14 16:50:39 +0000<br>
&gt;&gt; &gt;Commit:=C2=A0 =C2=A0 =C2=A0Adam Weinberger &lt;adamw@FreeBSD.o=
rg&gt;<br>
&gt;&gt; &gt;CommitDate: 2022-10-14 17:07:39 +0000<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 Mk: Add USES=3Dluajit<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 USES=3Dluajit centralizes luajit dependencies vi=
a<br>
&gt;&gt; <a href=3D"http://bsd.default-versions.mk" rel=3D"noreferrer" targ=
et=3D"_blank">bsd.default-versions.mk</a><br>
&gt;&gt; &gt;=C2=A0 =C2=A0 (defaulting to luajit-devel).<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 Ports currently depend on:<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0 lang/luajit: 42<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0 lang/luajit-devel: 0<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0 lang/luajit-openresty: 51<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 The difficulty here is that:<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0 - They all conflict with each other<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0 - Upstream is very clear about not intend=
ing for users to use the<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 version in lang/luajit at all, and=
 wants all luajit users to use<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 lang/luajit-devel<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0 - luajit-openresty is very aggressive abo=
ut being drop-in compatible<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 with luajit-devel (though not the =
other direction)<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 For the vast majority of situations, USES=3Dluaj=
it will be sufficient.<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 Ports that use openresty&#39;s API additions can=
 specify<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 USES=3Dluajit:openresty.<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 I&#39;m adding this into head very early in the =
2022Q4 cycle so that<br>
&gt;&gt; there&#39;s<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 ample time to address the default. It&#39;s a di=
fficult decision. osa, the<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 maintainer of luajit and luajit-devel, prefers t=
hat the default be<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 luajit, but I went the other direction because i=
t&#39;s in direct conflict<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 with upstream&#39;s clear stated intention. It&#=
39;s not a simple decision;<br>
&gt;&gt; see<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 the review below for a little discussion on it.<=
br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 The TL;DR here is that this defaults to the one =
luajit version that no<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 port currently depends on. However, this version=
 is what OpenBSD,<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 Homebrew, Ubuntu, Debian, Fedora, MacPorts, and =
Arch default to (and<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 none of them even provide the stale version lang=
/luajit provides).<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 This will bring FreeBSD in line with nearly ever=
y other OS package<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 system, and with upstream&#39;s intention.<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 See also PRs 225342, 257051.<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 bapt, tcberner<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 portmgr (bapt, tcberne=
r)<br>
&gt;&gt; &gt;=C2=A0 =C2=A0 Differential Revision:=C2=A0 <a href=3D"https://=
reviews.freebsd.org/D36947" rel=3D"noreferrer" target=3D"_blank">https://re=
views.freebsd.org/D36947</a><br>
&gt;&gt; &gt;---<br>
&gt;&gt; &gt; Mk/Uses/<a href=3D"http://luajit.mk" rel=3D"noreferrer" targe=
t=3D"_blank">luajit.mk</a>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 27 +++++++++=
++++++++++++++++++<br>
&gt;&gt; &gt; Mk/<a href=3D"http://bsd.default-versions.mk" rel=3D"noreferr=
er" target=3D"_blank">bsd.default-versions.mk</a> |=C2=A0 9 ++++++---<br>
&gt;&gt; &gt; 2 files changed, 33 insertions(+), 3 deletions(-)<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;diff --git a/Mk/Uses/<a href=3D"http://luajit.mk" rel=3D"noref=
errer" target=3D"_blank">luajit.mk</a> b/Mk/Uses/<a href=3D"http://luajit.m=
k" rel=3D"noreferrer" target=3D"_blank">luajit.mk</a><br>
&gt;&gt; &gt;new file mode 100644<br>
&gt;&gt; &gt;index 000000000000..75e54407d484<br>
&gt;&gt; &gt;--- /dev/null<br>
&gt;&gt; &gt;+++ b/Mk/Uses/<a href=3D"http://luajit.mk" rel=3D"noreferrer" =
target=3D"_blank">luajit.mk</a><br>
&gt;&gt; &gt;@@ -0,0 +1,27 @@<br>
&gt;&gt; &gt;+# Select your favorite luajit runtime<br>
&gt;&gt; &gt;+# Feature:=C2=A0 =C2=A0 luajit<br>
&gt;&gt; &gt;+# Usage:=C2=A0 =C2=A0 =C2=A0 USES=3D=C2=A0 luajit[:version]<b=
r>
&gt;&gt; &gt;+# MAINTAINER: adamw@FreeBSD.org<br>
&gt;&gt; &gt;+<br>
&gt;&gt; &gt;+.if !defined(_INCLUDE_USES_LUAJIT_MK)<br>
&gt;&gt; &gt;+_INCLUDE_USES_LUAJIT_MK=3Dyes<br>
&gt;&gt; &gt;+<br>
&gt;&gt; &gt;+.if !empty(luajit_ARGS)<br>
&gt;&gt; &gt;+LUAJIT_VER=3D=C2=A0 =C2=A0${luajit_ARGS}<br>
&gt;&gt; &gt;+.else<br>
&gt;&gt; &gt;+LUAJIT_VER=3D=C2=A0 =C2=A0${LUAJIT_DEFAULT}<br>
&gt;&gt; &gt;+.endif<br>
&gt;&gt; &gt;+<br>
&gt;&gt; &gt;+# When adding a version, please keep the comment in<br>
&gt;&gt; &gt;+# Mk/<a href=3D"http://bsd.default-versions.mk" rel=3D"norefe=
rrer" target=3D"_blank">bsd.default-versions.mk</a> in sync<br>
&gt;&gt; &gt;+VALID_LUAJIT_VER=3D=C2=A0 =C2=A0 =C2=A0luajit luajit-devel lu=
ajit-openresty<br>
&gt;&gt; &gt;+<br>
&gt;&gt; &gt;+.if empty(VALID_LUAJIT_VER:M${LUAJIT_DEFAULT})<br>
&gt;&gt; &gt;+IGNORE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0Invalid luajit default ve=
rsion ${LUAJIT_DEFAULT}: valid<br>
&gt;&gt; versions are ${VALID_LUAJIT_VER}<br>
&gt;&gt; &gt;+.elif empty(VALID_LUAJIT_VER:M${LUAJIT_VER})<br>
&gt;&gt; &gt;+IGNORE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0Invalid luajit version ${=
LUAJIT_VER}: valid versions are<br>
&gt;&gt; ${VALID_LUAJIT_VER}<br>
&gt;&gt; &gt;+.endif<br>
&gt;&gt; &gt;+<br>
&gt;&gt; &gt;+LIB_DEPENDS=3D=C2=A0 libluajit-5.1.so:lang/${LUAJIT_VER}<br>
&gt;&gt; &gt;+<br>
&gt;&gt; &gt;+.endif<br>
&gt;&gt; &gt;diff --git a/Mk/<a href=3D"http://bsd.default-versions.mk" rel=
=3D"noreferrer" target=3D"_blank">bsd.default-versions.mk</a> b/Mk/<a href=
=3D"http://bsd.default-versions.mk" rel=3D"noreferrer" target=3D"_blank">bs=
d.default-versions.mk</a><br>
&gt;&gt; &gt;index bbf3d5880c70..5a36e0b9c4d0 100644<br>
&gt;&gt; &gt;--- a/Mk/<a href=3D"http://bsd.default-versions.mk" rel=3D"nor=
eferrer" target=3D"_blank">bsd.default-versions.mk</a><br>
&gt;&gt; &gt;+++ b/Mk/<a href=3D"http://bsd.default-versions.mk" rel=3D"nor=
eferrer" target=3D"_blank">bsd.default-versions.mk</a><br>
&gt;&gt; &gt;@@ -17,9 +17,10 @@ _INCLUDE_BSD_DEFAULT_VERSIONS_MK=3D=C2=A0 =
=C2=A0yes<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt; LOCALBASE?=3D=C2=A0 =C2=A0/usr/local<br>
&gt;&gt; &gt;<br>
&gt;&gt; &gt;-.=C2=A0 for lang in APACHE BDB COROSYNC EMACS FIREBIRD FORTRA=
N FPC GCC<br>
&gt;&gt; GHOSTSCRIPT GL GO \<br>
&gt;&gt; &gt;-=C2=A0 =C2=A0 =C2=A0 IMAGEMAGICK JAVA LAZARUS LIBRSVG2 LINUX =
LLVM LUA MONO MYSQL NINJA<br>
&gt;&gt; NODEJS PERL5 \<br>
&gt;&gt; &gt;-=C2=A0 =C2=A0 =C2=A0 PGSQL PHP PYTHON PYTHON2 PYTHON3 RUBY RU=
ST SAMBA SSL TCLTK VARNISH<br>
&gt;&gt; &gt;+.=C2=A0 for lang in APACHE BDB COROSYNC EMACS FIREBIRD FORTRA=
N FPC GCC \<br>
&gt;&gt; &gt;+=C2=A0 =C2=A0 =C2=A0 GHOSTSCRIPT GL GO IMAGEMAGICK JAVA LAZAR=
US LIBRSVG2 LINUX LLVM \<br>
&gt;&gt; &gt;+=C2=A0 =C2=A0 =C2=A0 LUA LUAJIT MONO MYSQL NINJA NODEJS PERL5=
 PGSQL PHP PYTHON \<br>
&gt;&gt; &gt;+=C2=A0 =C2=A0 =C2=A0 PYTHON2 PYTHON3 RUBY RUST SAMBA SSL TCLT=
K VARNISH<br>
&gt;&gt; &gt; .=C2=A0 =C2=A0 if defined(${lang}_DEFAULT)<br>
&gt;&gt; &gt; ERROR+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0&quot;The variable ${lang=
}_DEFAULT is set and it should only be<br>
&gt;&gt; defined through DEFAULT_VERSIONS+=3D${lang:tl}=3D${${lang}_DEFAULT=
} in<br>
&gt;&gt; /etc/make.conf&quot;<br>
&gt;&gt; &gt; .=C2=A0 =C2=A0 endif<br>
&gt;&gt; &gt;@@ -86,6 +87,8 @@ LLVM_DEFAULT?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A090<br>
&gt;&gt; &gt; .=C2=A0 endif<br>
&gt;&gt; &gt; # Possible values: 5.1, 5.2, 5.3, 5.4<br>
&gt;&gt; &gt; LUA_DEFAULT?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A05.2<br>
&gt;&gt; &gt;+# Possible values: luajit, luajit-devel, luajit-openresty<br>
&gt;&gt; &gt;+LUAJIT_DEFAULT?=3D=C2=A0 =C2=A0 =C2=A0 luajit-devel<br>
&gt;&gt; &gt; # Possible values: 5.10, 5.20, 6.8<br>
&gt;&gt; &gt; MONO_DEFAULT=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A05.10<br>
&gt;&gt; &gt; # Possible values: 5.6, 5.7, 8.0, 10.3m, 10.4m, 10.5m, 5.7p, =
5.7w<br>
&gt;&gt;<br>
&gt;&gt; Could you make USES=3Dluajit default to openresty on powerpc64 and=
<br>
&gt;&gt; powerpc64le? lang/luajit and lang/luajit-devel don&#39;t support t=
hose, but<br>
&gt;&gt; openresty fork does.<br>
&gt;&gt;<br>
&gt;&gt; I believe aarch64 is in similar situation, except that it&#39;s al=
so<br>
&gt;&gt; supported by luajit-devel.<br>
&gt;&gt;<br>
&gt;<br>
&gt;Are you positive on that? luajit-devel just has IGNORE_riscv64 (which n=
o<br>
&gt;luajit works on), and includes a block specifically for powerpc*.<br>
It was originally added in<br>
<a href=3D"https://cgit.freebsd.org/ports/commit/lang/luajit/Makefile?id=3D=
d2ac3fee9c894bb6f10ab489a4b165f974fc1b03" rel=3D"noreferrer" target=3D"_bla=
nk">https://cgit.freebsd.org/ports/commit/lang/luajit/Makefile?id=3Dd2ac3fe=
e9c894bb6f10ab489a4b165f974fc1b03</a>.<br>
The review (at <a href=3D"https://reviews.freebsd.org/D13804" rel=3D"norefe=
rrer" target=3D"_blank">https://reviews.freebsd.org/D13804</a>) says:<br>
Successfully built on powerpc. Does not build for powerpc64, though.<br>
Later, that was copied to luajit-devel.<br>
Here&#39;s the most recent build on powerpc64le:<br>
<a href=3D"https://talos.anongoth.pl/data/latest-per-pkg/luajit-devel/2.1.0=
.20220815/powerpc64le-default.log" rel=3D"noreferrer" target=3D"_blank">htt=
ps://talos.anongoth.pl/data/latest-per-pkg/luajit-devel/2.1.0.20220815/powe=
rpc64le-default.log</a><br>
So that:<br>
.if ${ARCH:Mpowerpc*} || ${ARCH:Mmips*} || ${ARCH:Msparc*}<br>
can be replaced by just:<br>
.if ${ARCH} =3D=3D powerpc || ${ARCH} =3D=3D powerpcspe<br>
<br>
If you wish, the mips* and sparc64 parts can be added too, but I don&#39;t<=
br>
think there are any users left.<br></blockquote><div><br></div><div style=
=3D"font-family:arial,sans-serif" class=3D"gmail_default">Thank you!!</div>=
<div style=3D"font-family:arial,sans-serif" class=3D"gmail_default"><br></d=
iv><div style=3D"font-family:arial,sans-serif" class=3D"gmail_default">I&#3=
9;ll put a test for ${ARCH:Mpowerpc64*} in <a href=3D"http://bsd.default-ve=
rsions.mk">bsd.default-versions.mk</a>.</div><div style=3D"font-family:aria=
l,sans-serif" class=3D"gmail_default"><br></div><div style=3D"font-family:a=
rial,sans-serif" class=3D"gmail_default"># Adam</div><div style=3D"font-fam=
ily:arial,sans-serif" class=3D"gmail_default"><br></div><div style=3D"font-=
family:arial,sans-serif" class=3D"gmail_default"><br></div><div style=3D"fo=
nt-family:arial,sans-serif" class=3D"gmail_default"></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">
<br>
<br>
&gt;<br>
&gt;# Adam<br>
&gt;<br>
&gt;<br>
&gt;-- <br>
&gt;Adam Weinberger<br>
&gt;<a href=3D"mailto:adamw@adamw.org" target=3D"_blank">adamw@adamw.org</a=
> // adamw@FreeBSD.org<br>
&gt;<a href=3D"https://www.adamw.org" rel=3D"noreferrer" target=3D"_blank">=
https://www.adamw.org</a><br>;
</blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g=
mail_signature">Adam Weinberger<br><a href=3D"mailto:adamw@adamw.org" targe=
t=3D"_blank">adamw@adamw.org</a> // adamw@FreeBSD.org<br><a href=3D"https:/=
/www.adamw.org" target=3D"_blank">https://www.adamw.org</a></div></div>;

--0000000000000d3aaf05eb03c7c6--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcjxYq4eXERQeKM%2BrDjEWZz_qQW8rPKwFC=iUZDyHQFd-g>