Date: Tue, 10 Sep 2002 01:22:59 -1000 (HST) From: Vincent Poy <vince@oahu.WURLDLINK.NET> To: Martin Blapp <mb@imp.ch> Cc: current@FreeBSD.ORG Subject: Re: Uncommitted dc0 fixes ... Message-ID: <20020910012149.E2914-100000@oahu.WURLDLINK.NET> In-Reply-To: <20020910094649.C50626-100000@levais.imp.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 10 Sep 2002, Martin Blapp wrote: Hi, > > 1) dc driver uses wrong case to read MAC from eeprom. > > > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=kern/35482 > > > > This one seems to break data sending/receiving as the only thing that > > works is pinging and that's only on the alias/secondary IP and not the > > primary IP network which is completely unpingable. > > I expected this one to be the problem PR. I'll look at it this evening. I guess it's probably making everything detect as a EN5152B or something. > + case DC_DEVICEID_EN2242: /* and DC_DEVICEID_EN5251B: */ > + if (revision < DC_REVISION_EN5251B) { > + sc->dc_type = DC_TYPE_AN985; > + } else { > + sc->dc_type = DC_TYPE_EN5152B; > + } > + sc->dc_flags |= DC_TX_USE_TX_INTR; > + sc->dc_flags |= DC_TX_ADMTEK_WAR; > + sc->dc_pmode = DC_PMODE_MII; > + break; > case DC_DEVICEID_AN985: > - case DC_DEVICEID_EN2242: > sc->dc_type = DC_TYPE_AN985; > sc->dc_flags |= DC_TX_USE_TX_INTR; > sc->dc_flags |= DC_TX_ADMTEK_WAR; > > This change looks wrong to me. I guess it probably works for the originator of the PR. Cheers, Vince - vince@WURLDLINK.NET - Vice President ________ __ ____ Unix Networking Operations - FreeBSD-Real Unix for Free / / / / | / |[__ ] WurldLink Corporation / / / / | / | __] ] San Francisco - Honolulu - Hong Kong / / / / / |/ / | __] ] HongKong Stars/Gravis UltraSound Mailing Lists Admin /_/_/_/_/|___/|_|[____] Almighty1@IRC - oahu.DAL.NET Hawaii's DALnet IRC Network Server Admin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020910012149.E2914-100000>