Date: Tue, 11 Nov 2003 18:54:47 -0800 (PST) From: Alexander Kabaev <kan@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/sys mount.h src/sys/nfsclient nfs_vfsops.c src/sys/kern vfs_mount.c Message-ID: <200311120254.hAC2slF0028243@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
kan 2003/11/11 18:54:47 PST
FreeBSD src repository
Modified files:
sys/sys mount.h
sys/nfsclient nfs_vfsops.c
sys/kern vfs_mount.c
Log:
1. Consolidate mount struct allocation/destruction into a common code in
vfs_mount_alloc/vfs_mount_destroy functions and take care to completely
destroy the mount point along with its locks. Mount struct has grown in
coplexity recently and depending on each failure path to destroy it
completely isn't working anymore.
2. Eliminate largely identical vfs_mount and vfs_unmount question by
moving the code to handle both cases into a newly introduced vfs_domount
function.
3. Simplify nfs_mount_diskless to always expect an allocated mount
struct and never attempt an allocation/destruction itself. The
vfs_allocroot allocation was there to support 'magic' swap space
configuration for diskless clients that was already removed by PHK some
time ago.
4. Include a vfs_buildopts cleanups by Peter Edwards to validate the
sanity of nmount parameters passed from userland.
Submitted by: (4) Peter Edwards <peter.edwards@openet-telecom.com>
Reviewed by: rwatson
Revision Changes Path
1.113 +171 -429 src/sys/kern/vfs_mount.c
1.143 +3 -23 src/sys/nfsclient/nfs_vfsops.c
1.150 +1 -0 src/sys/sys/mount.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200311120254.hAC2slF0028243>