Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 22 May 2026 17:58:13 +0000
From:      Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav <des@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 76c3387024b4 - main - tftpd: Simplify packet drop macro
Message-ID:  <6a109935.395b1.372b3ce8@gitrepo.freebsd.org>
index | next in thread | raw e-mail 

The branch main has been updated by des:

URL: https://cgit.FreeBSD.org/src/commit/?id=76c3387024b40c2e28ed2d1bb64b3a14371c3c0b

commit 76c3387024b40c2e28ed2d1bb64b3a14371c3c0b
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2026-05-22 17:57:35 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2026-05-22 17:57:35 +0000

    tftpd: Simplify packet drop macro
    
    The first argument is always the function name, for which we can simply
    use __func__.  This leaves only the optional return value, so we can use
    a single variadic macro instead of two nearly-identical copies.
    
    MFC after:      1 week
    Reviewed by:    markj
    Differential Revision:  https://reviews.freebsd.org/D57076
---
 libexec/tftpd/tftp-io.c | 51 ++++++++++++++++++++++---------------------------
 1 file changed, 23 insertions(+), 28 deletions(-)

diff --git a/libexec/tftpd/tftp-io.c b/libexec/tftpd/tftp-io.c
index 3384071d6df2..3697c13f358f 100644
--- a/libexec/tftpd/tftp-io.c
+++ b/libexec/tftpd/tftp-io.c
@@ -69,17 +69,12 @@ static struct errmsg {
 	{ -1,		NULL }
 };
 
-#define DROPPACKET(s)							\
+#define DROPPACKET(...)							\
 	if (packetdroppercentage != 0 &&				\
-	    arc4random()%100 < packetdroppercentage) {			\
-		tftp_log(LOG_DEBUG, "Artificial packet drop in %s", s);	\
-		return;							\
-	}
-#define DROPPACKETn(s,n)						\
-	if (packetdroppercentage != 0 &&				\
-	    arc4random()%100 < packetdroppercentage) {			\
-		tftp_log(LOG_DEBUG, "Artificial packet drop in %s", s);	\
-		return (n);						\
+	    arc4random() % 100 < packetdroppercentage) {		\
+		tftp_log(LOG_DEBUG, "Artificial packet drop in %s",	\
+		    __func__);						\
+		return __VA_ARGS__;					\
 	}
 
 const char *
@@ -104,7 +99,7 @@ send_packet(int peer, uint16_t block, char *pkt, int size)
 	int t = 1;
 
 	for (i = 0; i < 12 ; i++) {
-		DROPPACKETn("send_packet", 0);
+		DROPPACKET(0);
 
 		if (sendto(peer, pkt, size, 0, (struct sockaddr *)&peer_sock,
 		    peer_sock.ss_len) == size) {
@@ -144,7 +139,7 @@ send_error(int peer, int error)
 	if (debug & DEBUG_PACKETS)
 		tftp_log(LOG_DEBUG, "Sending ERROR %d", error);
 
-	DROPPACKET("send_error");
+	DROPPACKET();
 
 	tp = (struct tftphdr *)buf;
 	tp->th_opcode = htons((u_short)ERROR);
@@ -179,12 +174,12 @@ send_wrq(int peer, char *filename, char *mode)
 	size_t len;
 	int n, size;
 
-	if (debug & DEBUG_PACKETS)
+	if (debug & DEBUG_PACKETS) {
 		tftp_log(LOG_DEBUG, "Sending WRQ: filename: '%s', mode '%s'",
-			filename, mode
-		);
+			filename, mode);
+	}
 
-	DROPPACKETn("send_wrq", 0);
+	DROPPACKET(0);
 
 	tp = (struct tftphdr *)buf;
 	tp->th_opcode = htons((u_short)WRQ);
@@ -209,7 +204,7 @@ send_wrq(int peer, char *filename, char *mode)
 	n = sendto(peer, buf, size, 0,
 	    (struct sockaddr *)&peer_sock, peer_sock.ss_len);
 	if (n != size) {
-		tftp_log(LOG_ERR, "send_wrq: %s", strerror(errno));
+		tftp_log(LOG_ERR, "%s: %m", __func__);
 		return (1);
 	}
 	return (0);
@@ -230,12 +225,12 @@ send_rrq(int peer, char *filename, char *mode)
 	size_t len;
 	int n, size;
 
-	if (debug & DEBUG_PACKETS)
+	if (debug & DEBUG_PACKETS) {
 		tftp_log(LOG_DEBUG, "Sending RRQ: filename: '%s', mode '%s'",
-			filename, mode
-		);
+		    filename, mode);
+	}
 
-	DROPPACKETn("send_rrq", 0);
+	DROPPACKET(0);
 
 	tp = (struct tftphdr *)buf;
 	tp->th_opcode = htons((u_short)RRQ);
@@ -262,7 +257,7 @@ send_rrq(int peer, char *filename, char *mode)
 	n = sendto(peer, buf, size, 0,
 	    (struct sockaddr *)&peer_sock, peer_sock.ss_len);
 	if (n != size) {
-		tftp_log(LOG_ERR, "send_rrq: %d %s", n, strerror(errno));
+		tftp_log(LOG_ERR, "%s: %m", __func__);
 		return (1);
 	}
 	return (0);
@@ -285,7 +280,7 @@ send_oack(int peer)
 	if (debug & DEBUG_PACKETS)
 		tftp_log(LOG_DEBUG, "Sending OACK");
 
-	DROPPACKETn("send_oack", 0);
+	DROPPACKET(0);
 
 	/*
 	 * Send back an options acknowledgement (only the ones with
@@ -299,8 +294,8 @@ send_oack(int peer)
 		if (options[i].o_reply != NULL) {
 			n = snprintf(bp, size, "%s%c%s", options[i].o_type,
 				     0, options[i].o_reply);
-			bp += n+1;
-			size -= n+1;
+			bp += n + 1;
+			size -= n + 1;
 			if (size < 0) {
 				tftp_log(LOG_ERR, "oack: buffer overflow");
 				exit(1);
@@ -331,7 +326,7 @@ send_ack(int fp, uint16_t block)
 	if (debug & DEBUG_PACKETS)
 		tftp_log(LOG_DEBUG, "Sending ACK for block %d", block);
 
-	DROPPACKETn("send_ack", 0);
+	DROPPACKET(0);
 
 	tp = (struct tftphdr *)buf;
 	tp->th_opcode = htons((u_short)ACK);
@@ -361,7 +356,7 @@ send_data(int peer, uint16_t block, char *data, int size)
 		tftp_log(LOG_DEBUG, "Sending DATA packet %d of %d bytes",
 			block, size);
 
-	DROPPACKETn("send_data", 0);
+	DROPPACKET(0);
 
 	pkt = (struct tftphdr *)buf;
 
@@ -408,7 +403,7 @@ receive_packet(int peer, char *data, int size, struct sockaddr_storage *from,
 	fromlen = sizeof(*pfrom);
 	n = recvfrom(peer, data, size, 0, (struct sockaddr *)pfrom, &fromlen);
 
-	DROPPACKETn("receive_packet", RP_TIMEOUT);
+	DROPPACKET(RP_TIMEOUT);
 
 	if (n < 0) {
 		/* No idea what could have happened if it isn't a timeout */
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a109935.395b1.372b3ce8>