Date: Mon, 26 Sep 2022 20:54:53 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Piotr Kubaj <pkubaj@anongoth.pl> Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: a29e9ae256a5 - main - security/picocrypt: Update i386 broken reason message Message-ID: <CAFDf7UJ3H9RUPLw7DJKknkFER9UGtCdhD6ax%2B1GYe-1xM0QWEw@mail.gmail.com> In-Reply-To: <YzDTmEPKnyoPd6MQ@talos> References: <202209252114.28PLE8lJ079144@gitrepo.freebsd.org> <YzDFDdPdkEVSBCFB@talos> <CAFDf7UJiJLMAoGQ%2BZsEc6EKtgqQGpJQjhWM2EAWRGp=5wBVHpw@mail.gmail.com> <YzDTmEPKnyoPd6MQ@talos>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000006ad61e05e999e71c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey Piotr, I've opted for a 64-bit whitelist because it is shorter than blacklist. Hope that is correct. https://cgit.freebsd.org/ports/commit/?id=3D860ce9aee61aacd34f0b1c29d54f44d= d86168835 Thanks for heads up! Cheers, Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia domingo, 25/09/2022 =C3=A0= (s) 23:17: > On 22-09-25 23:11:21, Nuno Teixeira wrote: > > Hi Piotr, > > > > Yes you are right. > > Maybe only mention 64-bit archs? > > > > ONLY_FOR_ARCHS=3D amd64 arm64 mips64 powerpc64 sparc64? > There's also powerpc64le and riscv64. > > > > Is there better way to mention only 32 or 64 bit? > I don't think ports tree allows it, you can either whitelist all the > 64-bit architectures or blacklist the 32-bit ones. > > > > Thanks > > > > > > > > Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia domingo, 25/09/2022 > =C3=A0(s) > > 22:15: > > > > > Why not disable on other 32-bit architectures? > > > > > > On 22-09-25 21:14:08, Nuno Teixeira wrote: > > > > The branch main has been updated by eduardo: > > > > > > > > URL: > > > > https://cgit.FreeBSD.org/ports/commit/?id=3Da29e9ae256a5ce7825e798b6701a1= 803a6ee4e76 > > > > > > > > commit a29e9ae256a5ce7825e798b6701a1803a6ee4e76 > > > > Author: Nuno Teixeira <eduardo@FreeBSD.org> > > > > AuthorDate: 2022-09-25 21:12:24 +0000 > > > > Commit: Nuno Teixeira <eduardo@FreeBSD.org> > > > > CommitDate: 2022-09-25 21:12:24 +0000 > > > > > > > > security/picocrypt: Update i386 broken reason message > > > > --- > > > > security/picocrypt/Makefile | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/security/picocrypt/Makefile > b/security/picocrypt/Makefile > > > > index 153ec8b94189..94881c7797bc 100644 > > > > --- a/security/picocrypt/Makefile > > > > +++ b/security/picocrypt/Makefile > > > > @@ -10,8 +10,8 @@ LICENSE=3D GPLv3 > > > > LICENSE_FILE=3D ${WRKSRC}/../LICENSE > > > > > > > > NOT_FOR_ARCHS=3D i386 > > > > -NOT_FOR_ARCHS_REASON=3D Picocrypt.go:53:11: cannot use 1 <<= 40 > > > (untyped int constant 1099511627776) as int value in variable > declaration > > > (overflows) \ > > > > - > > > https://github.com/HACKERALERT/Picocrypt/issues/127 > > > > +NOT_FOR_ARCHS_REASON=3D upstream only supports 64-bit > > > > +# https://github.com/HACKERALERT/Picocrypt/issues/127 > > > > > > > > LIB_DEPENDS=3D libharfbuzz.so:print/harfbuzz > > > > > > > > > > > > > -- > > Nuno Teixeira > > FreeBSD Committer (ports) > --=20 Nuno Teixeira FreeBSD Committer (ports) --0000000000006ad61e05e999e71c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hey Piotr,</div><div><br></div><div>I've opted fo= r a 64-bit whitelist because it is shorter than blacklist.</div><div>Hope t= hat is correct.</div><div><a href=3D"https://cgit.freebsd.org/ports/commit/= ?id=3D860ce9aee61aacd34f0b1c29d54f44dd86168835">https://cgit.freebsd.org/po= rts/commit/?id=3D860ce9aee61aacd34f0b1c29d54f44dd86168835</a></div><div><br= ></div><div>Thanks for heads up!</div><div><br></div><div>Cheers,<br></div>= </div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">= Piotr Kubaj <<a href=3D"mailto:pkubaj@anongoth.pl">pkubaj@anongoth.pl</a= >> escreveu no dia domingo, 25/09/2022 =C3=A0(s) 23:17:<br></div><blockq= uote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1p= x solid rgb(204,204,204);padding-left:1ex">On 22-09-25 23:11:21, Nuno Teixe= ira wrote:<br> > Hi Piotr,<br> > <br> > Yes you are right.<br> > Maybe only mention 64-bit archs?<br> > <br> > ONLY_FOR_ARCHS=3D amd64 arm64 mips64 powerpc64 sparc64?<br> There's also powerpc64le and riscv64.<br> > <br> > Is there better way to mention only 32 or 64 bit?<br> I don't think ports tree allows it, you can either whitelist all the<br= > 64-bit architectures or blacklist the 32-bit ones.<br> > <br> > Thanks<br> > <br> > <br> > <br> > Piotr Kubaj <<a href=3D"mailto:pkubaj@anongoth.pl" target=3D"_blank= ">pkubaj@anongoth.pl</a>> escreveu no dia domingo, 25/09/2022 =C3=A0(s)<= br> > 22:15:<br> > <br> > > Why not disable on other 32-bit architectures?<br> > ><br> > > On 22-09-25 21:14:08, Nuno Teixeira wrote:<br> > > > The branch main has been updated by eduardo:<br> > > ><br> > > > URL:<br> > > <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3Da29e9ae256= a5ce7825e798b6701a1803a6ee4e76" rel=3D"noreferrer" target=3D"_blank">https:= //cgit.FreeBSD.org/ports/commit/?id=3Da29e9ae256a5ce7825e798b6701a1803a6ee4= e76</a><br> > > ><br> > > > commit a29e9ae256a5ce7825e798b6701a1803a6ee4e76<br> > > > Author:=C2=A0 =C2=A0 =C2=A0Nuno Teixeira <eduardo@FreeBSD= .org><br> > > > AuthorDate: 2022-09-25 21:12:24 +0000<br> > > > Commit:=C2=A0 =C2=A0 =C2=A0Nuno Teixeira <eduardo@FreeBSD= .org><br> > > > CommitDate: 2022-09-25 21:12:24 +0000<br> > > ><br> > > >=C2=A0 =C2=A0 =C2=A0security/picocrypt: Update i386 broken re= ason message<br> > > > ---<br> > > >=C2=A0 security/picocrypt/Makefile | 4 ++--<br> > > >=C2=A0 1 file changed, 2 insertions(+), 2 deletions(-)<br> > > ><br> > > > diff --git a/security/picocrypt/Makefile b/security/picocryp= t/Makefile<br> > > > index 153ec8b94189..94881c7797bc 100644<br> > > > --- a/security/picocrypt/Makefile<br> > > > +++ b/security/picocrypt/Makefile<br> > > > @@ -10,8 +10,8 @@ LICENSE=3D=C2=A0 =C2=A0 GPLv3<br> > > >=C2=A0 LICENSE_FILE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ${WRKSRC}/.= ./LICENSE<br> > > ><br> > > >=C2=A0 NOT_FOR_ARCHS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0i386<br> > > > -NOT_FOR_ARCHS_REASON=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 Picocryp= t.go:53:11: cannot use 1 << 40<br> > > (untyped int constant 1099511627776) as int value in variable dec= laration<br> > > (overflows) \<br> > > > -<br> > > <a href=3D"https://github.com/HACKERALERT/Picocrypt/issues/127" r= el=3D"noreferrer" target=3D"_blank">https://github.com/HACKERALERT/Picocryp= t/issues/127</a><br> > > > +NOT_FOR_ARCHS_REASON=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 upstream= only supports 64-bit<br> > > > +# <a href=3D"https://github.com/HACKERALERT/Picocrypt/issue= s/127" rel=3D"noreferrer" target=3D"_blank">https://github.com/HACKERALERT/= Picocrypt/issues/127</a><br> > > ><br> > > >=C2=A0 LIB_DEPENDS=3D libharfbuzz.so:print/harfbuzz<br> > > ><br> > ><br> > <br> > <br> > -- <br> > Nuno Teixeira<br> > FreeBSD Committer (ports)<br> </blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g= mail_signature"><div dir=3D"ltr"><span style=3D"color:rgb(102,102,102)">Nun= o Teixeira<br>FreeBSD Committer (ports)</span></div></div> --0000000000006ad61e05e999e71c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJ3H9RUPLw7DJKknkFER9UGtCdhD6ax%2B1GYe-1xM0QWEw>