Date: Wed, 26 Mar 1997 11:27:54 GMT From: gavin@europe.shiva.com (Gavin Shearer) To: matt@3am-software.com, bugs@freebsd.org Subject: Changes to if_de.c for SMC9332BDT - are they correct? Message-ID: <199703261127.LAA23855@bombus.europe.shiva.com>
next in thread | raw e-mail | index | archive | help
Matt, I was looking at the changes in the "current" FreeBSD code to the if_de.c driver to support the new EtherPower 10/100 card. These changes seem to be the ones posted by John Capo to a news group. There is something about the changes which does not seem right. In the "tulip_boardsw_t" structure you can store four function pointers, in order: "probe", "select", "preset", and "mii_probe". The added "tulip_dc21140A_smc9332bdt_boardsw" structure has the "probe" pointing to "tulip_dc21140_smc9332_media_probe" (this is OK), but the "select" pointing to "tulip_dc21140_mii_media_preset" and the "preset" pointing to "tulip_dc21140_mii_probe". These last two seem to point to the wrong type of function. Gavin -- Gavin Shearer <gavin@europe.shiva.com>, Shiva Europe, +44 131 561 4219
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199703261127.LAA23855>