Date: Tue, 15 Jul 2014 18:30:11 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Ian Lepore <ian@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r268660 - head/sys/amd64/amd64 Message-ID: <20140715153011.GR93733@kib.kiev.ua> In-Reply-To: <1405432340.1312.26.camel@revolution.hippie.lan> References: <201407150930.s6F9Uhgi052394@svn.freebsd.org> <1405432340.1312.26.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Tue, Jul 15, 2014 at 07:52:20AM -0600, Ian Lepore wrote:
> > bcopy(a_cp, b_cp, cnt);
> > + if (__predict_false(pinned)) {
> > + sched_unpin();
> > + mtx_unlock(&cpage_lock);
> > + pinned = FALSE;
>
> Should this pinned = FALSE be done under the cpage_lock to avoid a race?
What race ? Could you describe it in more details ?
Note that pinned is local variable.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBAgAGBQJTxUkCAAoJEJDCuSvBvK1Bvq0P/19GAobGUQmVkQlBd6knD201
lPIcHH+TOtpUYePTndxqIwVO+o+oK/R8S9g+1WdFZh3g6ptcNCJGjKB8VNJvHkny
0D61Lkvg/5OyQLWTBgOO2nZu5sIWcjRn3Bsg+lA+2BpCrTsRbvt3w1sXWYuNBRcg
RqLB2HaNcC6PvHU3nFec5DkSvp3yg6wt3B2xTiOpA6tYsni8u80BSBAngSyidD0H
P++vmQmQcwYduvkM/DVeW4ovoImOLu7dqVxfHGs7mDZF1SoZOcFJXwQhQMN1j4ho
0gYeMduyfxVX6P9rSm90Fn2CrLE6YtwY/wETsrjlK8VFOY4JRe1HC6DAJg2XlDsf
iKiy9a+wBJOMLB92R0y+ABVfDJBaXeFqYvHbov66HTNC96Jg9KfzKF/bxgF+Qb/q
5hpv+Yk5u5Q6Hw+WycekbRte9yXQDiFXSTZqvoLuoD5g7XY2W0CGIB/eYynUfhGc
aIOEiWq8nfWij09Snic9kV4eCNR7LtMYNMKPknnlN2KE6+vBzbGKjANv55aP/WJY
pvDLaWF0KAfqn/M61wK869oifpEGIYH6/YQ+kuLBKNhcit3b+/DN7pY/WYQou1yy
h1uExTgqkdG9jkjE1pvOD7ejXVEsUOLQg5wwu5QmeMgVImgYuBUH60RZECFNAYKM
EoESPnA/KwXZ6c2On+AL
=KA00
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140715153011.GR93733>