Date: Sat, 21 Mar 2009 14:05:28 GMT From: Henry Karpatskij <henkka@spheroid.fi> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/132905: security/oidentd build faild on 8.0-CURRENT Message-ID: <200903211405.n2LE5S6R093965@www.freebsd.org> Resent-Message-ID: <200903211410.n2LEA2F0032577@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 132905
>Category: ports
>Synopsis: security/oidentd build faild on 8.0-CURRENT
>Confidential: no
>Severity: serious
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 21 14:10:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Henry Karpatskij
>Release: 8.0-CURRENT
>Organization:
>Environment:
FreeBSD flame.spheroid.fi 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Fri Mar 20 10:57:47 EET 2009 henkka@flame.spheroid.fi:/usr/obj/usr/src/sys/FLAME sparc64
>Description:
Build fails with:
if cc -DHAVE_CONFIG_H -I. -I. -I.. "-Imissing" -funsigned-char -O2 -pipe -fno-strict-aliasing -MT oidentd.o -MD -MP -MF ".deps/oidentd.Tpo" -c -o oidentd.o oidentd.c; then mv -f ".deps/oidentd.Tpo" ".deps/oidentd.Po"; else rm -f ".deps/oidentd.Tpo"; exit 1; fi
./oidentd_util.h:61: error: nested function 'randval' declared but never defined
*** Error code 1
>How-To-Repeat:
Just "make".
>Fix:
Change the randval function to be non-inline. My C-skills are pretty limited so there might a be a Better Way to do it. Patch included, though.
Patch attached with submission follows:
diff -ur work/oidentd-2.0.8/src/oidentd_util.c work/oidentd-2.0.8-non-inline/src/oidentd_util.c
--- work/oidentd-2.0.8/src/oidentd_util.c 2009-03-21 16:04:09.000000000 +0200
+++ work/oidentd-2.0.8-non-inline/src/oidentd_util.c 2009-03-21 16:05:54.000000000 +0200
@@ -75,7 +75,7 @@
** PRNG functions on systems whose libraries provide them.)
*/
-inline int randval(int i) {
+int randval(int i) {
/* Per _Numerical Recipes in C_: */
return ((double) i * rand() / (RAND_MAX+1.0));
}
diff -ur work/oidentd-2.0.8/src/oidentd_util.h work/oidentd-2.0.8-non-inline/src/oidentd_util.h
--- work/oidentd-2.0.8/src/oidentd_util.h 2009-03-21 16:04:21.000000000 +0200
+++ work/oidentd-2.0.8-non-inline/src/oidentd_util.h 2009-03-21 16:05:54.000000000 +0200
@@ -58,7 +58,7 @@
int find_group(const char *temp_group, gid_t *gid);
int random_seed(void);
-inline int randval(int i);
+int randval(int i);
#ifndef HAVE_SNPRINTF
int snprintf(char *str, size_t n, char const *fmt, ...);
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903211405.n2LE5S6R093965>