Date: Fri, 05 Mar 2021 12:46:46 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Kyle Evans <kevans@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: bb6e84c988d3 - main - poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c. Message-ID: <202103052046.125KkkJ2004952@slippy.cwsent.com> In-Reply-To: <CACNAnaE9xBWJdxuUnUmz8=Qe7GaekJL0Gm=Hwcnoma3F=97d9w@mail.gmail.com> References: <202103051755.125HtZsc073704@gitrepo.freebsd.org> <CACNAnaE9xBWJdxuUnUmz8=Qe7GaekJL0Gm=Hwcnoma3F=97d9w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <CACNAnaE9xBWJdxuUnUmz8=Qe7GaekJL0Gm=Hwcnoma3F=97d9w@mail.gmail.c om> , Kyle Evans writes: > On Fri, Mar 5, 2021 at 11:55 AM John Baldwin <jhb@freebsd.org> wrote: > > > > The branch main has been updated by jhb: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=bb6e84c988d3f54eff602ed544ceaa > 9b9fe3e9ff > > > > commit bb6e84c988d3f54eff602ed544ceaa9b9fe3e9ff > > Author: John Baldwin <jhb@FreeBSD.org> > > AuthorDate: 2021-03-05 17:47:58 +0000 > > Commit: John Baldwin <jhb@FreeBSD.org> > > CommitDate: 2021-03-05 17:55:11 +0000 > > > > poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c > . > > > > There currently isn't a need to provide a public interface to a > > software Poly1305 implementation beyond what is already available via > > libsodium's APIs and these symbols conflict with symbols shared within > > the ossl.ko module between ossl_poly1305.c and ossl_chacha20.c. > > > > Reported by: se, kp > > Fixes: 78991a93eb9d > > Sponsored by: Netflix > > --- > > sys/opencrypto/xform_poly1305.c | 43 ++++++++++++------------------------- > ---- > > sys/opencrypto/xform_poly1305.h | 16 --------------- > > 2 files changed, 12 insertions(+), 47 deletions(-) > > xform_poly1305.h also needs to stop being grouped in > ^/include/Makefile (reported by jenkins via np) > This resolves the build failure. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202103052046.125KkkJ2004952>