Date: Wed, 9 Feb 2011 21:42:58 +0800 From: Sunpoet Hsieh <sunpoet@sunpoet.net> To: arrowdodger <6yearold@gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. Message-ID: <AANLkTikwEoU=O5%2BncTPEOZMaMGFfoDLC_Q%2Bnr_NbWiec@mail.gmail.com> In-Reply-To: <AANLkTi=uPh6PJiBcNWyMRnWK9Wf18R9eY91%2Be1CXRTgQ@mail.gmail.com> References: <AANLkTin%2BCskJf8vP9iZwRvtC%2B66F%2BD6VPr6JbbO4v6pT@mail.gmail.com> <AANLkTimHUP5YvMrLuJ9NKET0=FyEO-M-5P8GJAJeU%2Bek@mail.gmail.com> <AANLkTi=uPh6PJiBcNWyMRnWK9Wf18R9eY91%2Be1CXRTgQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 9, 2011 at 5:15 PM, arrowdodger <6yearold@gmail.com> wrote:
> On Tue, Feb 8, 2011 at 9:29 PM, Sunpoet Hsieh <sunpoet@sunpoet.net> wrote=
:
>>
>> Hi,
>>
>> First of all, I suggest to set PORTNAME=3Dtortoisehg
>> If you do want to add -hgtk suffix, you may set PKGNAMESUFFIX=3D-hgtk
>> instead.
>> It makes portlint happier.
>> It also simplifies Makefile since DISTNAME is already the default value.
>
> Well, i added -hgtk because TortoiseHG 2.0 (which will be released at Mar=
ch)
> will be using PyQT, but current GTK version will be supported as long as =
it
> is used. So, user will be able to choose between hgtk if he prefers GTK o=
r
> pyqt if he likes Qt. It is not an option for a port, but two different
> programs and they can be installed simultaneously.
> Maybe the port itself should be called tortoisehg-hgtk?
>
It looks like you'll have two ports, version 1 and 2, and these two
ports do not conflict with each other.
IMHO, I would simply use devel/tortoisehg1 for version 1 and
devel/tortoisehg for upcoming version 2.
You do not need to add -gtk or -pyqt suffix to emphasize the use of GTK or =
Qt.
>> In your case, it can be done without extra patch files.
>>
>> .if !defined(WITH_NAUTILUS)
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0@${REINPLACE_CMD} -e '153,154 D' ${WRKSRC}/${=
PYSETUP}
>> .endif
>> .if !defined(WITH_NLS)
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0@${REINPLACE_CMD} -e '150,152 D' ${WRKSRC}/${=
PYSETUP}
>> .endif
>
> That's definetely nicer than any patches.
>
>> Here, I suggest a shorter option name "NAUTILUS" instead of
>> "NAUTILUS_EXTENSION".
>> Also, for PLIST_SUB, I think "NLS" is OK for most ports.
>>
>> .if !defined(WITH_NLS)
>> PLIST_SUB+=3D =C2=A0 =C2=A0 NLS=3D"@comment "
>> .else
>> PLIST_SUB+=3D =C2=A0 =C2=A0 NLS=3D""
>> .endif
>
> Will do.
>
>>
>> > 2. The port also installs *.egg-info file and i'm not sure how to
>> > include it
>> > in the plist.
>>
>> You should set PYDISTUTILS_EGGINFO=3D<egg-info files>.
>> bsd.python.mk will add them to PLIST automatically.
>>
>> PYDISTUTILS_EGGINFO defaults to tortoisehg-1.1.9.1-py2.6.egg-info.
>> (when PORTNAME=3Dtortoisehg)
>
> What if PORTNAME!=3Dtortoisehg? I mean, if i'm setting PYDISTUTILS_EGGINF=
O,
> where should i obtain that -py2.6- part?
PYDISTUTILS_EGGINFO defaults to
${PYDISTUTILS_PKGNAME:C/[^A-Za-z0-9.]+/_/g}-${PYDISTUTILS_PKGVERSION:C/[^A-=
Za-z0-9.]+/_/g}-${PYTHON_VERSION:S/thon//}.egg-info
(Mk/bsd.python.mk, around line 509)
For Python versions, see PYTHON_VERSION, PYTHON_PORTVERSION and PYTHON_VER.
(Mk/bsd.python.mk, around line 372-410)
--=20
=C2=A0 Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.=
org>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B =
8CC0 DC44 247E CC57 E36B
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikwEoU=O5%2BncTPEOZMaMGFfoDLC_Q%2Bnr_NbWiec>