Date: Sun, 21 Oct 2012 21:11:09 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh <imp@freebsd.org> Subject: Re: svn commit: r241757 - head/usr.sbin/pciconf Message-ID: <12563773-B5F9-4F48-A1A7-45E15296F9C4@bsdimp.com> In-Reply-To: <201210200830.26755.jhb@freebsd.org> References: <201210192248.q9JMmMpt093234@svn.freebsd.org> <201210200830.26755.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 20, 2012, at 6:30 AM, John Baldwin wrote: > On Friday, October 19, 2012 06:48:22 PM Warner Losh wrote: >> Author: imp >> Date: Fri Oct 19 22:48:22 2012 >> New Revision: 241757 >> URL: http://svn.freebsd.org/changeset/base/241757 >> >> Log: >> Indent ecaps the same way we indent caps. > > This was on purpose so the '=' signs line up It makes it hard to parse otherwise... Perhaps the equal lining up should be documented? Or at least be fixed to match everything else. When ecaps were added the broke indentation... I'm happy to fix the alignment issue. Warner > . In fact, prior to this change, > all of the equal signs line up: > > igb0@pci0:8:0:0: class=0x020000 card=0x10a715d9 chip=0x10a78086 > rev=0x02 hdr=0x00 > vendor = 'Intel Corporation' > device = '82575EB Gigabit Network Connection' > class = network > subclass = ethernet > bar [10] = type Memory, range 32, base 0xda020000, size 131072, enabled > bar [14] = type Memory, range 32, base 0xda000000, size 131072, enabled > bar [18] = type I/O Port, range 32, base 0x3000, size 32, enabled > bar [1c] = type Memory, range 32, base 0xda080000, size 16384, enabled > cap 01[40] = powerspec 2 supports D0 D3 current D0 > cap 05[50] = MSI supports 1 message, 64 bit > cap 11[60] = MSI-X supports 10 messages in map 0x1c enabled > cap 10[a0] = PCI-Express 2 endpoint max data 128(256) link x4(x4) > ecap 0001[100] = AER 1 0 fatal 0 non-fatal 1 corrected > ecap 0003[140] = Serial 1 003048ffff5f9170 > PCI-e errors = Correctable Error Detected > Unsupported Request Detected > Corrected = Advisory Non-Fatal Error > > > -- > John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?12563773-B5F9-4F48-A1A7-45E15296F9C4>