Date: Thu, 9 Mar 2023 08:21:27 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: Danilo Egea Gondolfo <danilo@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e7b134bf62ce - main - devel/aws-sdk-cpp: Update to 1.11.25 Message-ID: <CAFDf7UKmXx8LPwo6uVAk-FDQ83msUq02Ess2zJ8XRD_4mrehRA@mail.gmail.com> In-Reply-To: <CAFDf7ULhOc1uAFw=KfpZB3iv4NXoh_1vGO3d6bO1=tg4qzBWoA@mail.gmail.com> References: <202302271328.31RDScwO056423@gitrepo.freebsd.org> <e9ed6f0d-d593-3423-da74-7ee12c3a8b27@gmail.com> <04e9e204-a2f1-cbac-c7ff-d07f70ba1738@FreeBSD.org> <CAFDf7ULhOc1uAFw=KfpZB3iv4NXoh_1vGO3d6bO1=tg4qzBWoA@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hello Danilo, Done at 3486eb8 Thanks, Nuno Teixeira <eduardo@freebsd.org> escreveu no dia quinta, 2/03/2023 à(s) 13:34: > Hello Danilo, > > I will test it on i386 too to figure it out. > If it is like you said, I'll remove broken_tests very soon. > > Thanks, > > Danilo Egea Gondolfo <danilo@freebsd.org> escreveu no dia segunda, > 27/02/2023 à(s) 16:32: > >> On 27/02/2023 14:30, Danilo Egea Gondolfo wrote: >> >> > On 27/02/2023 13:28, Nuno Teixeira wrote: >> > >> >> The branch main has been updated by eduardo: >> >> >> >> URL: >> >> >> https://cgit.FreeBSD.org/ports/commit/?id=e7b134bf62ce15bd1daf1f7fbed512262baa8eea >> >> >> >> commit e7b134bf62ce15bd1daf1f7fbed512262baa8eea >> >> Author: Nuno Teixeira <eduardo@FreeBSD.org> >> >> AuthorDate: 2023-02-27 09:00:18 +0000 >> >> Commit: Nuno Teixeira <eduardo@FreeBSD.org> >> >> CommitDate: 2023-02-27 13:28:07 +0000 >> >> >> >> devel/aws-sdk-cpp: Update to 1.11.25 >> >> - fix TEST option that was wrongly set to ON and causing >> >> build failures >> >> on some 32bit archs. >> >> - unbreak on mentioned archs >> > >> > Interesting. Does that mean the build will not work on 32bit archs if >> > TEST is enabled? >> > >> > As the former maintainer of devel/aws-sdk-cpp I'm just curious. >> > >> > I didn't really try but if it's building on 32bit archs now the real >> > reason might be this refactoring mentioned in the changelog for >> > version 1.11.0 >> > >> > >> https://github.com/aws/aws-sdk-cpp/blob/main/CHANGELOG.md#1110-2022-01-24 >> > >> > The build would fail before because they generate huge unified cpp >> > files (option ENABLE_UNITY_BUILD) that were making a single instance >> > of the compiler to use more than 4GB of memory (more than 6GB actually >> > on 64bit). >> > >> > Anyway, I'm glad you fixed it for 32 bit archs. Thanks :) >> > >> Just test on i386. The build failed with tests because there are tests >> failing, not because the compiler is consuming too much memory. >> >> I'd say those TEST_BROKEN could all be removed. >> >> >> >> ChangeLog: >> >> https://github.com/aws/aws-sdk-cpp/compare/1.11.10...1.11.25 >> >> PR: 269837 >> >> Reported by: John Hein <jcfyecrayz@liamekaens.com> >> >> --- >> >> devel/aws-sdk-cpp/Makefile | 13 ++++++------- >> >> devel/aws-sdk-cpp/distinfo | 6 +++--- >> >> 2 files changed, 9 insertions(+), 10 deletions(-) >> >> >> >> diff --git a/devel/aws-sdk-cpp/Makefile b/devel/aws-sdk-cpp/Makefile >> >> index 94de9263a751..608d138e75bb 100644 >> >> --- a/devel/aws-sdk-cpp/Makefile >> >> +++ b/devel/aws-sdk-cpp/Makefile >> >> @@ -1,5 +1,5 @@ >> >> PORTNAME= aws-sdk-cpp >> >> -DISTVERSION= 1.11.10 >> >> +DISTVERSION= 1.11.25 >> >> CATEGORIES= devel >> >> MAINTAINER= eduardo@FreeBSD.org >> >> @@ -9,11 +9,6 @@ WWW= https://github.com/aws/aws-sdk-cpp >> >> LICENSE= APACHE20 >> >> LICENSE_FILE= ${WRKSRC}/LICENSE >> >> -BROKEN_armv6= fails to build: runaway process >> >> -BROKEN_armv7= fails to build: runaway process >> >> -BROKEN_i386= fails to build: compiler runs out of memory >> >> -BROKEN_powerpc= fails to build: compiler runs out of memory >> >> - >> >> LIB_DEPENDS= libaws-c-auth.so:security/aws-c-auth \ >> >> libaws-c-cal.so:security/aws-c-cal \ >> >> libaws-c-common.so:devel/aws-c-common \ >> >> @@ -58,7 +53,11 @@ BUILD_ONLY?= >> >> OPTIONS_DEFINE= TEST >> >> OPTIONS_SUB= yes >> >> -TEST_CMAKE_BOOL_OFF= ENABLE_TESTING >> >> +TEST_CMAKE_BOOL= ENABLE_TESTING >> >> +TEST_BROKEN_armv6= fails to build: runaway process >> >> +TEST_BROKEN_armv7= fails to build: runaway process >> >> +TEST_BROKEN_i386= fails to build: compiler runs out of memory >> >> +TEST_BROKEN_powerpc= fails to build: compiler runs out of memory >> >> pre-everything:: >> >> @${ECHO_MSG} >> >> diff --git a/devel/aws-sdk-cpp/distinfo b/devel/aws-sdk-cpp/distinfo >> >> index df6d21d967f7..2a639227971b 100644 >> >> --- a/devel/aws-sdk-cpp/distinfo >> >> +++ b/devel/aws-sdk-cpp/distinfo >> >> @@ -1,3 +1,3 @@ >> >> -TIMESTAMP = 1675456421 >> >> -SHA256 (aws-aws-sdk-cpp-1.11.10_GH0.tar.gz) = >> >> e1370a57252147df35bd8860f35ad69548bb46077adf7524c2d1dd02ee8aa643 >> >> -SIZE (aws-aws-sdk-cpp-1.11.10_GH0.tar.gz) = 49752262 >> >> +TIMESTAMP = 1677440274 >> >> +SHA256 (aws-aws-sdk-cpp-1.11.25_GH0.tar.gz) = >> >> 1103cf18516ca70d76c062af5a2b5c2418c5162235895baf3550a9f356d69f10 >> >> +SIZE (aws-aws-sdk-cpp-1.11.25_GH0.tar.gz) = 49938123 >> > > > -- > Nuno Teixeira > FreeBSD Committer (ports) > -- Nuno Teixeira FreeBSD Committer (ports) [-- Attachment #2 --] <div dir="ltr"><div>Hello Danilo,</div><div><br></div><div>Done at 3486eb8</div><div><br></div><div>Thanks,<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Nuno Teixeira <<a href="mailto:eduardo@freebsd.org">eduardo@freebsd.org</a>> escreveu no dia quinta, 2/03/2023 à(s) 13:34:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hello Danilo,</div><div><br></div><div>I will test it on i386 too to figure it out.</div><div>If it is like you said, I'll remove broken_tests very soon.</div><div><br></div><div>Thanks,<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Danilo Egea Gondolfo <<a href="mailto:danilo@freebsd.org" target="_blank">danilo@freebsd.org</a>> escreveu no dia segunda, 27/02/2023 à(s) 16:32:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 27/02/2023 14:30, Danilo Egea Gondolfo wrote:<br> <br> > On 27/02/2023 13:28, Nuno Teixeira wrote:<br> ><br> >> The branch main has been updated by eduardo:<br> >><br> >> URL: <br> >> <a href="https://cgit.FreeBSD.org/ports/commit/?id=e7b134bf62ce15bd1daf1f7fbed512262baa8eea" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=e7b134bf62ce15bd1daf1f7fbed512262baa8eea</a><br>; >><br> >> commit e7b134bf62ce15bd1daf1f7fbed512262baa8eea<br> >> Author: Nuno Teixeira <eduardo@FreeBSD.org><br> >> AuthorDate: 2023-02-27 09:00:18 +0000<br> >> Commit: Nuno Teixeira <eduardo@FreeBSD.org><br> >> CommitDate: 2023-02-27 13:28:07 +0000<br> >><br> >> devel/aws-sdk-cpp: Update to 1.11.25<br> >> - fix TEST option that was wrongly set to ON and causing <br> >> build failures<br> >> on some 32bit archs.<br> >> - unbreak on mentioned archs<br> ><br> > Interesting. Does that mean the build will not work on 32bit archs if <br> > TEST is enabled?<br> ><br> > As the former maintainer of devel/aws-sdk-cpp I'm just curious.<br> ><br> > I didn't really try but if it's building on 32bit archs now the real <br> > reason might be this refactoring mentioned in the changelog for <br> > version 1.11.0<br> ><br> > <a href="https://github.com/aws/aws-sdk-cpp/blob/main/CHANGELOG.md#1110-2022-01-24" rel="noreferrer" target="_blank">https://github.com/aws/aws-sdk-cpp/blob/main/CHANGELOG.md#1110-2022-01-24</a><br>; ><br> > The build would fail before because they generate huge unified cpp <br> > files (option ENABLE_UNITY_BUILD) that were making a single instance <br> > of the compiler to use more than 4GB of memory (more than 6GB actually <br> > on 64bit).<br> ><br> > Anyway, I'm glad you fixed it for 32 bit archs. Thanks :)<br> ><br> Just test on i386. The build failed with tests because there are tests <br> failing, not because the compiler is consuming too much memory.<br> <br> I'd say those TEST_BROKEN could all be removed.<br> <br> <br> >> ChangeLog: <br> >> <a href="https://github.com/aws/aws-sdk-cpp/compare/1.11.10...1.11.25" rel="noreferrer" target="_blank">https://github.com/aws/aws-sdk-cpp/compare/1.11.10...1.11.25</a><br>; >> PR: 269837<br> >> Reported by: John Hein <<a href="mailto:jcfyecrayz@liamekaens.com" target="_blank">jcfyecrayz@liamekaens.com</a>><br> >> ---<br> >> devel/aws-sdk-cpp/Makefile | 13 ++++++-------<br> >> devel/aws-sdk-cpp/distinfo | 6 +++---<br> >> 2 files changed, 9 insertions(+), 10 deletions(-)<br> >><br> >> diff --git a/devel/aws-sdk-cpp/Makefile b/devel/aws-sdk-cpp/Makefile<br> >> index 94de9263a751..608d138e75bb 100644<br> >> --- a/devel/aws-sdk-cpp/Makefile<br> >> +++ b/devel/aws-sdk-cpp/Makefile<br> >> @@ -1,5 +1,5 @@<br> >> PORTNAME= aws-sdk-cpp<br> >> -DISTVERSION= 1.11.10<br> >> +DISTVERSION= 1.11.25<br> >> CATEGORIES= devel<br> >> MAINTAINER= eduardo@FreeBSD.org<br> >> @@ -9,11 +9,6 @@ WWW= <a href="https://github.com/aws/aws-sdk-cpp" rel="noreferrer" target="_blank">https://github.com/aws/aws-sdk-cpp</a><br>; >> LICENSE= APACHE20<br> >> LICENSE_FILE= ${WRKSRC}/LICENSE<br> >> -BROKEN_armv6= fails to build: runaway process<br> >> -BROKEN_armv7= fails to build: runaway process<br> >> -BROKEN_i386= fails to build: compiler runs out of memory<br> >> -BROKEN_powerpc= fails to build: compiler runs out of memory<br> >> -<br> >> LIB_DEPENDS= libaws-c-auth.so:security/aws-c-auth \<br> >> libaws-c-cal.so:security/aws-c-cal \<br> >> libaws-c-common.so:devel/aws-c-common \<br> >> @@ -58,7 +53,11 @@ BUILD_ONLY?=<br> >> OPTIONS_DEFINE= TEST<br> >> OPTIONS_SUB= yes<br> >> -TEST_CMAKE_BOOL_OFF= ENABLE_TESTING<br> >> +TEST_CMAKE_BOOL= ENABLE_TESTING<br> >> +TEST_BROKEN_armv6= fails to build: runaway process<br> >> +TEST_BROKEN_armv7= fails to build: runaway process<br> >> +TEST_BROKEN_i386= fails to build: compiler runs out of memory<br> >> +TEST_BROKEN_powerpc= fails to build: compiler runs out of memory<br> >> pre-everything::<br> >> @${ECHO_MSG}<br> >> diff --git a/devel/aws-sdk-cpp/distinfo b/devel/aws-sdk-cpp/distinfo<br> >> index df6d21d967f7..2a639227971b 100644<br> >> --- a/devel/aws-sdk-cpp/distinfo<br> >> +++ b/devel/aws-sdk-cpp/distinfo<br> >> @@ -1,3 +1,3 @@<br> >> -TIMESTAMP = 1675456421<br> >> -SHA256 (aws-aws-sdk-cpp-1.11.10_GH0.tar.gz) = <br> >> e1370a57252147df35bd8860f35ad69548bb46077adf7524c2d1dd02ee8aa643<br> >> -SIZE (aws-aws-sdk-cpp-1.11.10_GH0.tar.gz) = 49752262<br> >> +TIMESTAMP = 1677440274<br> >> +SHA256 (aws-aws-sdk-cpp-1.11.25_GH0.tar.gz) = <br> >> 1103cf18516ca70d76c062af5a2b5c2418c5162235895baf3550a9f356d69f10<br> >> +SIZE (aws-aws-sdk-cpp-1.11.25_GH0.tar.gz) = 49938123<br> </blockquote></div><br clear="all"><br>-- <br><div dir="ltr"><div dir="ltr"><span style="color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committer (ports)</span></div></div> </blockquote></div><br clear="all"><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><span style="color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committer (ports)</span></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UKmXx8LPwo6uVAk-FDQ83msUq02Ess2zJ8XRD_4mrehRA>