Date: Mon, 11 Jan 2016 13:19:34 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Ravi Pokala <rpokala@mac.com> Cc: Allan Jude <allanjude@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r292788 - in head/sys: geom/part sys Message-ID: <CAOfEmZj3zXtYtcXKBES%2Bz0UoEiyAEgW2CpKqQQHdYohmt7cXOQ@mail.gmail.com> In-Reply-To: <1F9E33A5-A9D7-44A9-9519-2A1593BFF990@panasas.com> References: <201512271812.tBRICD3A044563@repo.freebsd.org> <1F9E33A5-A9D7-44A9-9519-2A1593BFF990@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
IMHO, if it can't be something generic that other people can use it, it is a NO GO! -1 2016-01-11 12:54 GMT+08:00 Ravi Pokala <rpokala@mac.com>: > Hi folks, > > I have a Panasas-proprietary GPT UUID that I'd like to commit upstream. > There's ~zero chance anyone outside of Panasas or our customers would ever > see it, but we're trying to reduce gratuitous differences against upstream, > and this is a good candidate. When I mentioned this at the November 2015 > DevSummit, no one there objected. > > There was a recent change in this area, which brought up some questions. > See below: > > -----Original Message----- > > > From: <owner-src-committers@freebsd.org> on behalf of Allan Jude > <allanjude@FreeBSD.org> > Date: 2015-12-27, Sunday at 10:12 > To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, < > svn-src-head@freebsd.org> > Subject: svn commit: r292788 - in head/sys: geom/part sys > > >Author: allanjude > >Date: Sun Dec 27 18:12:13 2015 > >New Revision: 292788 > >URL: https://svnweb.freebsd.org/changeset/base/292788 > > > >Log: > > Add some additional GPT partition types > > > >... > > > > Differential Revision: https://reviews.freebsd.org/D3841 > > > >... > > > > In that review, there was discussion about the sorting of aliases in (enum > g_part_alias). It was originally thought that the aliases needed to be > sorted, due to binary searching in g_part_alias_name(). It turned out that > g_part_alias_name() did a linear search, so the list didn't strictly need > to be sorted. But, there was talk of potentially switching to a binary > search later, so Allan went with the sorted version. > > ae@ and kib@ voiced some concerns: > > From: <owner-src-committers@freebsd.org> on behalf of "Andrey V. Elsukov" > <bu7cher@yandex.ru> > Date: 2015-12-28, Monday at 00:32 > To: Allan Jude <allanjude@FreeBSD.org>, <src-committers@freebsd.org>, < > svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> > Subject: Re: svn commit: r292788 - in head/sys: geom/part sys > > > > This enum could be used by third-party kernel module and in general it > > is not good to change the order of elements here. This can break `gpart > > show` output for such modules. Just for the future. :) > > > From: <owner-src-committers@freebsd.org> on behalf of Konstantin Belousov > <kostikbel@gmail.com> > Date: 2015-12-28, Monday at 02:49 > To: "Andrey V. Elsukov" <bu7cher@yandex.ru> > Cc: Allan Jude <allanjude@FreeBSD.org>, <src-committers@freebsd.org>, < > svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> > Subject: Re: svn commit: r292788 - in head/sys: geom/part sys > > > > If the enum values are considered part of KBI, then explicit assignment > > of the enum values is much preferred. > > > As best as I can tell, nothing in base/head or ports/head looks at the GPT > UUIDs or aliases (outside of GEOM_PART itself, of course), so ae@ and kib@'s > concerns are not an issue at this time. Therefore, my plan is to insert the > new alias and UUID entries into the various enums and lists in-order, > rather than just appending. Any objections? > > Thanks, > > Ravi (rpokala@) > > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZj3zXtYtcXKBES%2Bz0UoEiyAEgW2CpKqQQHdYohmt7cXOQ>