Date: Wed, 7 Nov 2018 13:12:17 +0100 From: Baptiste Daroussin <bapt@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Koichiro Iwao <meta@freebsd.org>, Niclas Zeising <zeising@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r484357 - head/mail/spamassassin Message-ID: <20181107121217.p5ira4vn556t4t2z@ivaldir.net> In-Reply-To: <20181107101513.GA81078@FreeBSD.org> References: <201811062146.wA6LknN3005274@repo.freebsd.org> <20181107083105.55o52urafcgdthec@ivaldir.net> <20181107091004.xbvzfyviyrkcbi2m@icepick.vmeta.jp> <ca100d9e-c455-27c3-5605-2ecbb3c5a4bb@freebsd.org> <20181107092211.dgcvichyunbss35x@ivaldir.net> <2b3670de-7625-d458-7c93-5ea0a7ae2af1@freebsd.org> <20181107095528.szgl6dytu7zuos5r@icepick.vmeta.jp> <20181107101513.GA81078@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--aaqltdrvglpqvyyj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 07, 2018 at 10:15:13AM +0000, Alexey Dokuchaev wrote: > On Wed, Nov 07, 2018 at 06:55:28PM +0900, Koichiro Iwao wrote: > > ... > > +1 to single port. I concern about not all people need that patch. Can > > FLAVORS be used to create packages with/without Japanese patches? > > I know it can be used to handle multiple versions of PHP, Python, etc. >=20 > There's nothing wrong with a patch not being *useful* to all people, > the question is would it break anything for anyone. If there are no > undesired side effects just commit it without hiding it behind options > or flavors. >=20 > ./danfe I agree with danfe here! if needed we can in the end play with flavors yes, but if the patch does not break things to anyone and brings good for japane= se people let's just have the patch in and no options/flavors :) Best regards, Bapt --aaqltdrvglpqvyyj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlvi1p0ACgkQY4mL3PG3 PloY/xAApbGylez7yAb1b7FxnBumqkPG6fcnKVKIeUgHJ93GZzxlTafwHtqIIvaG scpn3A9IJV2Ilwf8wwQXyK++6tQSEwD32ywveZ0pGy4dSmmkmSEDJKE8KljbB4Tr MuMIWPLb2K4zTLvXFbL1S8Me7LJYCwzRu1+h7lURfUyVHA6YWhSodhgSZbv1Mw9C VT4kQC8Y9yi7xi6YrKGt1tpM9OqJ9zX4V/YA6fPwyk0KyCYFAqMH59d4pSF+AMET uQcofL3stzAbRegnonVxm5SCJ3EPkcH8ru1wSYSle4NusVcQ3fML/Q0pClKUNuL2 G/FWJrof8lTD7xfFTwECUQhdz1Lh9ZbYCbxXmRlQcZ55UvX8W2VZh/ic7Saoa53Z NIyolWYR/zPVWU9MwhQlwLJOYcPw5p2WQHiNxa8RQBnwi6q7ao75dsx3m2RqPB0S OU86XATtizP6Nbf2OxjWEhOH4l84fzeew/hkrJN9G+8TjQHTnGwHQLPl/tFpYXY1 QuI9fQdclL8X7ZS7vasN33phjbflrAgHoO6MR4ECAZETvIhjKbd06GMcedqlI/HZ vc99UQ2jjH+z1IvEVz1wO6WiJfYe1fDf5+nh42GhpUmtubXrsF2ZTUeOot+Sxpun oAcvSek4Dvzw6dMfpIfdcfOM5MVeQsDEO4CNJTLez6RypNVoUMo= =HTb/ -----END PGP SIGNATURE----- --aaqltdrvglpqvyyj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181107121217.p5ira4vn556t4t2z>