Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Jul 2004 19:56:03 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 58479 for review
Message-ID:  <200407291956.i6TJu3Ux053411@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=58479

Change 58479 by jhb@jhb_slimer on 2004/07/29 19:55:07

	Properly move gcc membar before the store.
	
	Submitted by: gibbs

Affected files ...

.. //depot/projects/smpng/sys/i386/include/atomic.h#15 edit

Differences ...

==== //depot/projects/smpng/sys/i386/include/atomic.h#15 (text+ko) ====

@@ -190,8 +190,8 @@
 static __inline void					\
 atomic_store_rel_##TYPE(volatile u_##TYPE *p, u_##TYPE v)\
 {							\
+	__asm __volatile("" : : : "memory");		\
 	*p = v;						\
-	__asm __volatile("" : : : "memory");		\
 }							\
 struct __hack
 
@@ -214,8 +214,8 @@
 static __inline void					\
 atomic_store_rel_##TYPE(volatile u_##TYPE *p, u_##TYPE v)\
 {							\
+	__asm __volatile("" : : : "memory");		\
 	*p = v;						\
-	__asm __volatile("" : : : "memory");		\
 }							\
 struct __hack
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407291956.i6TJu3Ux053411>