Date: Tue, 12 Sep 2023 03:21:30 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Antoine Brodin <antoine@freebsd.org>, "Tobias C. Berner" <tcberner@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 7bb64b89d0e5 - main - framework: add Mk/Uses/pycryptography Message-ID: <CAMHz58StKswggDWY=%2B9ecMP6_eYantD2uGbYL1DTRZkT9pNBjQ@mail.gmail.com> In-Reply-To: <CAMHz58S2ALF-42p9a6GGzyVVmNNC9rZaai5fOFOTWSCFBq=dog@mail.gmail.com> References: <202307220748.36M7mgIt016872@gitrepo.freebsd.org> <CAALwa8ntOrr3TB7WALhWMrj59_f2=THeuMzQDJt29hHAVpQZkw@mail.gmail.com> <CAOshKte4QVfiRuqrJMfJeF2Qc%2BuLhJOo2v=CLUVdceS=SiSapA@mail.gmail.com> <CAMHz58S2ALF-42p9a6GGzyVVmNNC9rZaai5fOFOTWSCFBq=dog@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
Hello,
On Tue, Aug 1, 2023 at 2:31 AM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote:
> Hello,
>
> How about USE_PYTHON={cryptography_build,cryptography,cryptography_test}?
> USE_PYTHON=cryptography is the runtime dependency because it is mostly
> used in RUN_DEPENDS.
>
> For the current ports tree, I get the following result via "git grep
> pycryptography":
> 89 USES=pycryptography:run
> 5 USES=pycryptography:test
> 2 USES=pycryptography:run,test
> 1 USES=pycryptography:build,run
> 0 USES=pycryptography
>
>
I've submitted PR 273727 for this.
Thanks.
Regards,
sunpoet
> Regards,
> sunpoet
>
> On Mon, Jul 24, 2023 at 10:54 PM Tobias C. Berner <tcberner@freebsd.org>
> wrote:
>
>> Moin moin
>>
>> It seemed an easier way to stop-gap fix this issue separately. But
>> you're probably right, that python.mk would be the preferred location
>> to do so.
>>
>> I can move it there.
>>
>>
>> mfg Tobias
>>
>> On Sat, 22 Jul 2023 at 14:51, Antoine Brodin <antoine@freebsd.org> wrote:
>> >
>> > On Sat, Jul 22, 2023 at 7:48 AM Tobias C. Berner <tcberner@freebsd.org>
>> wrote:
>> > >
>> > > The branch main has been updated by tcberner:
>> > >
>> > > URL:
>> https://cgit.FreeBSD.org/ports/commit/?id=7bb64b89d0e5ec8d77b28f8341269ffbad279ebf
>> > >
>> > > commit 7bb64b89d0e5ec8d77b28f8341269ffbad279ebf
>> > > Author: Tobias C. Berner <tcberner@FreeBSD.org>
>> > > AuthorDate: 2023-07-22 06:16:46 +0000
>> > > Commit: Tobias C. Berner <tcberner@FreeBSD.org>
>> > > CommitDate: 2023-07-22 07:46:38 +0000
>> > >
>> > > framework: add Mk/Uses/pycryptography
>> > >
>> > > With the added new DEFAULT_VERSION
>> "PYCRYPTOGRAHY_DEFAULT=rust|legacy"
>> > > it is important to transparently depend on the right one.
>> > >
>> > > This is the job of this new uses.
>> > >
>> > > So instead of manually adding dependency lines like
>> > >
>> > >
>> RUN_DEPENDS=${PYTHON_PKGNAMEPREFIX}cryptography>0:security/py-cryptography@
>> ${PY_FLAVOR}
>> > >
>> > > this should now be
>> > >
>> > > USES=pycryptography:run
>> > >
>> > > Supported arguments: <none>,build,run,test
>> > > If no argument is given, it defaults to 'build,run'.
>> > >
>> > > A future commit will update to security/py-cryptography will
>> introduce a
>> > > rust dependency.
>> > >
>> > > PR: 254853
>> >
>> > Hi,
>> >
>> > Why isn't it a USE_PYTHON= pycryptography?
>> >
>> > Antoine
>>
>
[-- Attachment #2 --]
<div dir="ltr"><div>Hello,</div><div><br></div><div>On Tue, Aug 1, 2023 at 2:31 AM Po-Chuan Hsieh <<a href="mailto:sunpoet@freebsd.org">sunpoet@freebsd.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hello,</div><div><br></div><div>How about USE_PYTHON={cryptography_build,cryptography,cryptography_test}?</div><div>USE_PYTHON=cryptography is the runtime dependency because it is mostly used in RUN_DEPENDS.</div><div><br></div><div>For the current ports tree, I get the following result via "git grep pycryptography":</div><div>89 USES=pycryptography:run</div><div> 5 USES=pycryptography:test</div><div> 2 USES=pycryptography:run,test</div><div> 1 USES=pycryptography:build,run</div><div> 0 USES=pycryptography</div><div><br></div></div></blockquote><div><br></div><div>I've submitted PR 273727 for this.</div><div>Thanks.</div><div><br></div><div>Regards,</div><div>sunpoet</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div><div>Regards,</div><div>sunpoet</div><div><br></div><div>On Mon, Jul 24, 2023 at 10:54 PM Tobias C. Berner <<a href="mailto:tcberner@freebsd.org" target="_blank">tcberner@freebsd.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Moin moin<br>
<br>
It seemed an easier way to stop-gap fix this issue separately. But<br>
you're probably right, that <a href="http://python.mk" rel="noreferrer" target="_blank">python.mk</a> would be the preferred location<br>
to do so.<br>
<br>
I can move it there.<br>
<br>
<br>
mfg Tobias<br>
<br>
On Sat, 22 Jul 2023 at 14:51, Antoine Brodin <<a href="mailto:antoine@freebsd.org" target="_blank">antoine@freebsd.org</a>> wrote:<br>
><br>
> On Sat, Jul 22, 2023 at 7:48 AM Tobias C. Berner <<a href="mailto:tcberner@freebsd.org" target="_blank">tcberner@freebsd.org</a>> wrote:<br>
> ><br>
> > The branch main has been updated by tcberner:<br>
> ><br>
> > URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=7bb64b89d0e5ec8d77b28f8341269ffbad279ebf" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=7bb64b89d0e5ec8d77b28f8341269ffbad279ebf</a><br>;
> ><br>
> > commit 7bb64b89d0e5ec8d77b28f8341269ffbad279ebf<br>
> > Author: Tobias C. Berner <tcberner@FreeBSD.org><br>
> > AuthorDate: 2023-07-22 06:16:46 +0000<br>
> > Commit: Tobias C. Berner <tcberner@FreeBSD.org><br>
> > CommitDate: 2023-07-22 07:46:38 +0000<br>
> ><br>
> > framework: add Mk/Uses/pycryptography<br>
> ><br>
> > With the added new DEFAULT_VERSION "PYCRYPTOGRAHY_DEFAULT=rust|legacy"<br>
> > it is important to transparently depend on the right one.<br>
> ><br>
> > This is the job of this new uses.<br>
> ><br>
> > So instead of manually adding dependency lines like<br>
> ><br>
> > RUN_DEPENDS=${PYTHON_PKGNAMEPREFIX}cryptography>0:security/py-cryptography@${PY_FLAVOR}<br>
> ><br>
> > this should now be<br>
> ><br>
> > USES=pycryptography:run<br>
> ><br>
> > Supported arguments: <none>,build,run,test<br>
> > If no argument is given, it defaults to 'build,run'.<br>
> ><br>
> > A future commit will update to security/py-cryptography will introduce a<br>
> > rust dependency.<br>
> ><br>
> > PR: 254853<br>
><br>
> Hi,<br>
><br>
> Why isn't it a USE_PYTHON= pycryptography?<br>
><br>
> Antoine<br>
</blockquote></div></div>
</blockquote></div></div>
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58StKswggDWY=%2B9ecMP6_eYantD2uGbYL1DTRZkT9pNBjQ>