Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Jan 2014 11:26:42 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Akinori MUSHA <knu@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r340703 - in head/databases/mysql-q4m: . files
Message-ID:  <20140122112642.GA53001@FreeBSD.org>
In-Reply-To: <201401221103.s0MB3j3r098232@svn.freebsd.org>
References:  <201401221103.s0MB3j3r098232@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 22, 2014 at 11:03:45AM +0000, Akinori MUSHA wrote:
> New Revision: 340703
> URL: http://svnweb.freebsd.org/changeset/ports/340703
> 
> +USE_PERL5=	yes
>  USE_GMAKE=	yes

Hmm, why not employ USES for gmake and perl5?

> -CPPFLAGS+=	${PTHREAD_CFLAGS} -I${LOCALBASE}/include
> +CPPFLAGS+=	${PTHREAD_CFLAGS} -I${LOCALBASE}/include -DDBUG_OFF

PTHREAD_CFLAGS is empty for a long time; you could've simply omitted it
completely here.

> -	cd ${WRKSRC}; ${PERL} run_tests.pl
> +	cd ${WRKSRC}; ./run_tests.pl

I'm not sure if this change actually makes things better: it now depends
on correct shebang, and +x permission on the script.  What was wrong with
invoking the script through ${PERL}?

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140122112642.GA53001>