Date: Sat, 8 Nov 2014 19:03:04 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274274 - head/sys/net Message-ID: <20141108160304.GQ1031@FreeBSD.org> In-Reply-To: <8B3F77C9-C79D-4303-ADB6-310B3928D51C@FreeBSD.org> References: <201411080723.sA87N2hx046823@svn.freebsd.org> <8B3F77C9-C79D-4303-ADB6-310B3928D51C@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 08, 2014 at 03:06:20PM +0000, Bjoern A. Zeeb wrote: B> > Modified: head/sys/net/if.c B> > ============================================================================== B> > --- head/sys/net/if.c Sat Nov 8 06:43:33 2014 (r274273) B> > +++ head/sys/net/if.c Sat Nov 8 07:23:01 2014 (r274274) B> > @@ -265,13 +265,12 @@ ifnet_byindex_ref(u_short idx) B> > * Allocate an ifindex array entry; return 0 on success or an error on B> > * failure. B> > */ B> > -static int B> > -ifindex_alloc_locked(u_short *idxp) B> > +static u_short B> B> That feels like going backwards; we should really make sure we can support ifindexes >> 64k This isn't backwards, since if_index was u_short before the commit. I will take into account your wish and see if we can enlarge if_index. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141108160304.GQ1031>