Date: Fri, 30 Apr 2021 14:40:56 +0000 From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 230996] em/igb: Intel i210/i350: ifconfig: enabling "vlanhwtag" renders VLAN on i210/i350 NICs unusable Message-ID: <bug-230996-7501-psUYHeG6hM@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-230996-7501@https.bugs.freebsd.org/bugzilla/> References: <bug-230996-7501@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230996 --- Comment #26 from Kaho Toshikazu <kaho@elam.kais.kyoto-u.ac.jp> --- (In reply to Kevin Bowling from comment #25) I don't test review D30002, but I think it contains some inappropriate parts relating in "1. Call down to the hw support routine on vlan register and unregister events".=20 I think that "call hw support" would not be solve the problem but make other trouble. I think vlan register/unregister parts in current c= odes=20 are not broken. I think that using E1000_WRITE_REG_ARRAY directly is a obvious bug which was introduced at iflib conversion.=20 The driver stores a device specific function for writing vfta into the e1000_write_vfta variable, and should use this variable as a function of writing vfta. At first, correcting only this area is a good course, I think. --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230996-7501-psUYHeG6hM>